Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1003)

Side by Side Diff: tools/perf/measurements/rasterize_and_record_micro.py

Issue 376183005: Update rasterized_and_record_micro to use results.AddValue(...) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2013 The Chromium Authors. All rights reserved. 1 # Copyright 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import sys 5 import sys
6 import time 6 import time
7 7
8 from telemetry.core.util import TimeoutException 8 from telemetry.core.util import TimeoutException
9 from telemetry.page import page_measurement 9 from telemetry.page import page_measurement
10 from telemetry.page import page_test 10 from telemetry.page import page_test
11 from telemetry.value import scalar
12
11 13
12 class RasterizeAndRecordMicro(page_measurement.PageMeasurement): 14 class RasterizeAndRecordMicro(page_measurement.PageMeasurement):
13 def __init__(self): 15 def __init__(self):
14 super(RasterizeAndRecordMicro, self).__init__('') 16 super(RasterizeAndRecordMicro, self).__init__('')
15 self._chrome_branch_number = None 17 self._chrome_branch_number = None
16 18
17 @classmethod 19 @classmethod
18 def AddCommandLineArgs(cls, parser): 20 def AddCommandLineArgs(cls, parser):
19 parser.add_option('--start-wait-time', type='float', 21 parser.add_option('--start-wait-time', type='float',
20 default=2, 22 default=2,
(...skipping 66 matching lines...) Expand 10 before | Expand all | Expand 10 after
87 tab.WaitForJavaScriptExpression( 89 tab.WaitForJavaScriptExpression(
88 'window.benchmark_results.done', self.options.timeout) 90 'window.benchmark_results.done', self.options.timeout)
89 91
90 data = tab.EvaluateJavaScript('window.benchmark_results.results') 92 data = tab.EvaluateJavaScript('window.benchmark_results.results')
91 93
92 pixels_recorded = data['pixels_recorded'] 94 pixels_recorded = data['pixels_recorded']
93 record_time = data['record_time_ms'] 95 record_time = data['record_time_ms']
94 pixels_rasterized = data['pixels_rasterized'] 96 pixels_rasterized = data['pixels_rasterized']
95 rasterize_time = data['rasterize_time_ms'] 97 rasterize_time = data['rasterize_time_ms']
96 98
97 results.Add('pixels_recorded', 'pixels', pixels_recorded) 99 results.AddValue(scalar.ScalarValue(
98 results.Add('record_time', 'ms', record_time) 100 results.current_page, 'pixels_recorded', 'pixels', pixels_recorded))
99 results.Add('pixels_rasterized', 'pixels', pixels_rasterized) 101 results.AddValue(scalar.ScalarValue(
100 results.Add('rasterize_time', 'ms', rasterize_time) 102 results.current_page, 'record_time', 'ms', record_time))
103 results.AddValue(scalar.ScalarValue(
104 results.current_page, 'pixels_rasterized', 'pixels', pixels_rasterized))
105 results.AddValue(scalar.ScalarValue(
106 results.current_page, 'rasterize_time', 'ms', rasterize_time))
101 107
102 # TODO(skyostil): Remove this temporary workaround when reference build has 108 # TODO(skyostil): Remove this temporary workaround when reference build has
103 # been updated to branch 1931 or later. 109 # been updated to branch 1931 or later.
104 if ((self._chrome_branch_number and self._chrome_branch_number >= 1931) or 110 if ((self._chrome_branch_number and self._chrome_branch_number >= 1931) or
105 sys.platform == 'android'): 111 sys.platform == 'android'):
106 record_time_sk_null_canvas = data['record_time_sk_null_canvas_ms'] 112 record_time_sk_null_canvas = data['record_time_sk_null_canvas_ms']
107 record_time_painting_disabled = data['record_time_painting_disabled_ms'] 113 record_time_painting_disabled = data['record_time_painting_disabled_ms']
108 record_time_skrecord = data['record_time_skrecord_ms'] 114 record_time_skrecord = data['record_time_skrecord_ms']
109 results.Add('record_time_sk_null_canvas', 'ms', 115 results.AddValue(scalar.ScalarValue(
110 record_time_sk_null_canvas) 116 results.current_page, 'record_time_sk_null_canvas', 'ms',
111 results.Add('record_time_painting_disabled', 'ms', 117 record_time_sk_null_canvas))
112 record_time_painting_disabled) 118 results.AddValue(scalar.ScalarValue(
113 results.Add('record_time_skrecord', 'ms', record_time_skrecord) 119 results.current_page, 'record_time_painting_disabled', 'ms',
120 record_time_painting_disabled))
121 results.AddValue(scalar.ScalarValue(
122 results.current_page, 'record_time_skrecord', 'ms',
123 record_time_skrecord))
114 124
115 if self.options.report_detailed_results: 125 if self.options.report_detailed_results:
116 pixels_rasterized_with_non_solid_color = \ 126 pixels_rasterized_with_non_solid_color = \
117 data['pixels_rasterized_with_non_solid_color'] 127 data['pixels_rasterized_with_non_solid_color']
118 pixels_rasterized_as_opaque = \ 128 pixels_rasterized_as_opaque = \
119 data['pixels_rasterized_as_opaque'] 129 data['pixels_rasterized_as_opaque']
120 total_layers = data['total_layers'] 130 total_layers = data['total_layers']
121 total_picture_layers = data['total_picture_layers'] 131 total_picture_layers = data['total_picture_layers']
122 total_picture_layers_with_no_content = \ 132 total_picture_layers_with_no_content = \
123 data['total_picture_layers_with_no_content'] 133 data['total_picture_layers_with_no_content']
124 total_picture_layers_off_screen = \ 134 total_picture_layers_off_screen = \
125 data['total_picture_layers_off_screen'] 135 data['total_picture_layers_off_screen']
126 136
127 results.Add('pixels_rasterized_with_non_solid_color', 'pixels', 137 results.AddValue(scalar.ScalarValue(
128 pixels_rasterized_with_non_solid_color) 138 results.current_page, 'pixels_rasterized_with_non_solid_color',
129 results.Add('pixels_rasterized_as_opaque', 'pixels', 139 'pixels', pixels_rasterized_with_non_solid_color))
130 pixels_rasterized_as_opaque) 140 results.AddValue(scalar.ScalarValue(
131 results.Add('total_layers', 'count', total_layers) 141 results.current_page, 'pixels_rasterized_as_opaque', 'pixels',
132 results.Add('total_picture_layers', 'count', total_picture_layers) 142 pixels_rasterized_as_opaque))
133 results.Add('total_picture_layers_with_no_content', 'count', 143 results.AddValue(scalar.ScalarValue(
134 total_picture_layers_with_no_content) 144 results.current_page, 'total_layers', 'count', total_layers))
135 results.Add('total_picture_layers_off_screen', 'count', 145 results.AddValue(scalar.ScalarValue(
136 total_picture_layers_off_screen) 146 results.current_page, 'total_picture_layers', 'count',
147 total_picture_layers))
148 results.AddValue(scalar.ScalarValue(
149 results.current_page, 'total_picture_layers_with_no_content', 'count',
150 total_picture_layers_with_no_content))
151 results.AddValue(scalar.ScalarValue(
152 results.current_page, 'total_picture_layers_off_screen', 'count',
153 total_picture_layers_off_screen))
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698