Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Issue 376183004: Slim Skia down to just one murmur3 implementation. (Closed)

Created:
6 years, 5 months ago by mtklein_C
Modified:
6 years, 5 months ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : revert SkImageFilter changes so everything else can reland #

Patch Set 3 : Fix SkImageFilter cache? #

Patch Set 4 : &key is right #

Patch Set 5 : problem was strict aliasing #

Patch Set 6 : comment #

Patch Set 7 : types #

Patch Set 8 : apply may_alias on the argument without a typedef #

Patch Set 9 : revert test changes #

Patch Set 10 : move inside #

Patch Set 11 : fix types #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -32 lines) Patch
M src/core/SkChecksum.h View 1 2 3 4 5 6 7 8 9 10 4 chunks +17 lines, -6 lines 0 comments Download
M src/core/SkImageFilter.cpp View 2 3 3 chunks +2 lines, -26 lines 0 comments Download

Messages

Total messages: 22 (0 generated)
mtklein_C
6 years, 5 months ago (2014-07-09 15:10:02 UTC) #1
reed1
lgtm
6 years, 5 months ago (2014-07-09 15:17:44 UTC) #2
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 5 months ago (2014-07-09 15:29:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/376183004/1
6 years, 5 months ago (2014-07-09 15:30:25 UTC) #4
commit-bot: I haz the power
Change committed as 6ac0037b70410ff7d5ce5788bc89314223e1a587
6 years, 5 months ago (2014-07-09 15:49:11 UTC) #5
mtklein
A revert of this CL has been created in https://codereview.chromium.org/378413002/ by mtklein@google.com. The reason for ...
6 years, 5 months ago (2014-07-09 21:17:37 UTC) #6
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 5 months ago (2014-07-10 12:43:21 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/376183004/20001
6 years, 5 months ago (2014-07-10 12:43:57 UTC) #8
commit-bot: I haz the power
Change committed as 67a3271f0de9ccc32d559b042b862528272047cc
6 years, 5 months ago (2014-07-10 13:03:50 UTC) #9
mtklein
Please have another look?
6 years, 5 months ago (2014-07-10 19:05:04 UTC) #10
reed1
6 years, 5 months ago (2014-07-10 19:07:38 UTC) #11
reed1
lgtm
6 years, 5 months ago (2014-07-10 19:07:42 UTC) #12
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 5 months ago (2014-07-10 19:08:03 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/376183004/100001
6 years, 5 months ago (2014-07-10 19:08:45 UTC) #14
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 5 months ago (2014-07-10 19:19:18 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/376183004/120001
6 years, 5 months ago (2014-07-10 19:19:25 UTC) #16
commit-bot: I haz the power
Change committed as 53d435990bdb4d14df78013da45a9364d0287ebe
6 years, 5 months ago (2014-07-10 21:10:56 UTC) #17
reed1
A revert of this CL has been created in https://codereview.chromium.org/381253003/ by reed@google.com. The reason for ...
6 years, 5 months ago (2014-07-10 21:29:09 UTC) #18
mtklein
New contender for worst error message of the year! error: comparison between distinct pointer types ...
6 years, 5 months ago (2014-07-10 22:01:02 UTC) #19
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 5 months ago (2014-07-11 14:22:21 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/376183004/200001
6 years, 5 months ago (2014-07-11 14:23:15 UTC) #21
commit-bot: I haz the power
6 years, 5 months ago (2014-07-11 15:42:21 UTC) #22
Message was sent while issue was closed.
Change committed as 19fcc7494e68843cb9f2de819a7287ee216e3c5e

Powered by Google App Engine
This is Rietveld 408576698