Fix clipped keyboard settings overlay.

Fix clipped keyboard settings overlay.

There shouldn't be multiple content-areas housing the link-buttons.

See screenshots at http://crbug.com/392347.

BUG=392347
R=stevenjb@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283296

[Dan Beam, 2014-07-09 03:10:53]

https://chromiumcodereview.appspot.com/376093002/diff/1/chrome/browser/resour...
File chrome/browser/resources/options/chromeos/keyboard_overlay.html (right):

https://chromiumcodereview.appspot.com/376093002/diff/1/chrome/browser/resour...
chrome/browser/resources/options/chromeos/keyboard_overlay.html:96: </div>
use a .settings-row instead

[michaelpg, 2014-07-10 02:20:47]

https://chromiumcodereview.appspot.com/376093002/diff/1/chrome/browser/resour...
File chrome/browser/resources/options/chromeos/keyboard_overlay.html (right):

https://chromiumcodereview.appspot.com/376093002/diff/1/chrome/browser/resour...
chrome/browser/resources/options/chromeos/keyboard_overlay.html:96: </div>
On 2014/07/09 03:10:53, Dan Beam wrote:
> use a .settings-row instead

Done.

[Dan Beam, 2014-07-10 02:22:29]

https://chromiumcodereview.appspot.com/376093002/diff/40001/chrome/browser/re...
File chrome/browser/resources/options/chromeos/keyboard_overlay.html (right):

https://chromiumcodereview.appspot.com/376093002/diff/40001/chrome/browser/re...
chrome/browser/resources/options/chromeos/keyboard_overlay.html:80: <div
class="settings-row">
^ like this

https://chromiumcodereview.appspot.com/376093002/diff/40001/chrome/browser/re...
chrome/browser/resources/options/chromeos/keyboard_overlay.html:96: </div>
I meant:

  <div class="settings-row">
    <button>
    <button>
  </div>

or

  <div class="settings-row">
    <button ...>
  </div>
  <div class="settings-row">
    <button ...>
  </div>

if they need to be on separate lines (for some reason)

[Dan Beam, 2014-07-10 02:22:55]

FYI: don't use NOTRY=true for this, there are tests for the markup structure of
settings pages

[michaelpg, 2014-07-10 02:43:17]

https://chromiumcodereview.appspot.com/376093002/diff/40001/chrome/browser/re...
File chrome/browser/resources/options/chromeos/keyboard_overlay.html (right):

https://chromiumcodereview.appspot.com/376093002/diff/40001/chrome/browser/re...
chrome/browser/resources/options/chromeos/keyboard_overlay.html:96: </div>
On 2014/07/10 02:22:28, Dan Beam wrote:
> I meant:
> 
>   <div class="settings-row">
>     <button>
>     <button>
>   </div>
> 
> or
> 
>   <div class="settings-row">
>     <button ...>
>   </div>
>   <div class="settings-row">
>     <button ...>
>   </div>
> 
> if they need to be on separate lines (for some reason)

That's what I had at first, but I did a code search and there didn't seem to be
a specific structure. So I wasn't sure.

Searching for 'class=\"settings-row\"' turns up examples like

<div class="settings-row">
<span class="settings-row">
<label class="settings-row">

Can I ask what the <div> adds? Easier to see the structure in the code?

[Dan Beam, 2014-07-10 21:00:49]

https://chromiumcodereview.appspot.com/376093002/diff/40001/chrome/browser/re...
File chrome/browser/resources/options/chromeos/keyboard_overlay.html (right):

https://chromiumcodereview.appspot.com/376093002/diff/40001/chrome/browser/re...
chrome/browser/resources/options/chromeos/keyboard_overlay.html:96: </div>
On 2014/07/10 02:43:17, Michael Giuffrida wrote:
> On 2014/07/10 02:22:28, Dan Beam wrote:
> > I meant:
> > 
> >   <div class="settings-row">
> >     <button>
> >     <button>
> >   </div>
> > 
> > or
> > 
> >   <div class="settings-row">
> >     <button ...>
> >   </div>
> >   <div class="settings-row">
> >     <button ...>
> >   </div>
> > 
> > if they need to be on separate lines (for some reason)
> 
> That's what I had at first, but I did a code search and there didn't seem to
be
> a specific structure. So I wasn't sure.
> 
> Searching for 'class=\"settings-row\"' turns up examples like
> 
> <div class="settings-row">
> <span class="settings-row">
> <label class="settings-row">
> 
> Can I ask what the <div> adds? Easier to see the structure in the code?

<div>s are block

[michaelpg, 2014-07-10 21:06:46]

On 2014/07/10 21:00:49, Dan Beam wrote:
>
https://chromiumcodereview.appspot.com/376093002/diff/40001/chrome/browser/re...
> File chrome/browser/resources/options/chromeos/keyboard_overlay.html (right):
> 
>
https://chromiumcodereview.appspot.com/376093002/diff/40001/chrome/browser/re...
> chrome/browser/resources/options/chromeos/keyboard_overlay.html:96: </div>
> On 2014/07/10 02:43:17, Michael Giuffrida wrote:
> > On 2014/07/10 02:22:28, Dan Beam wrote:
> > > I meant:
> > > 
> > >   <div class="settings-row">
> > >     <button>
> > >     <button>
> > >   </div>
> > > 
> > > or
> > > 
> > >   <div class="settings-row">
> > >     <button ...>
> > >   </div>
> > >   <div class="settings-row">
> > >     <button ...>
> > >   </div>
> > > 
> > > if they need to be on separate lines (for some reason)
> > 
> > That's what I had at first, but I did a code search and there didn't seem to
> be
> > a specific structure. So I wasn't sure.
> > 
> > Searching for 'class=\"settings-row\"' turns up examples like
> > 
> > <div class="settings-row">
> > <span class="settings-row">
> > <label class="settings-row">
> > 
> > Can I ask what the <div> adds? Easier to see the structure in the code?
> 
> <div>s are block

As are .settings-row's.

[Dan Beam, 2014-07-10 22:23:55]

lgtm

[michaelpg, 2014-07-11 00:51:20]

The CQ bit was checked by michaelpg@chromium.org

[michaelpg, 2014-07-11 00:51:21]

The CQ bit was unchecked by michaelpg@chromium.org

[michaelpg, 2014-07-15 00:26:06]

stevenjb@ does this LGTY?

[stevenjb, 2014-07-15 00:34:48]

You can defer to Dan for any html/css changes, but lgtm fwiw.

[michaelpg, 2014-07-15 00:35:42]

On 2014/07/15 00:34:48, stevenjb wrote:
> You can defer to Dan for any html/css changes, but lgtm fwiw.

Just needed the owner stamp :-)

[michaelpg, 2014-07-15 00:35:45]

The CQ bit was checked by michaelpg@chromium.org

[stevenjb, 2014-07-15 00:39:37]

On 2014/07/15 00:35:42, Michael Giuffrida wrote:
> On 2014/07/15 00:34:48, stevenjb wrote:
> > You can defer to Dan for any html/css changes, but lgtm fwiw.
> 
> Just needed the owner stamp :-)

dbeam@ is an owner of c/b/resources/options which should be sufficient (for
future reference)

[commit-bot: I haz the power, 2014-07-15 00:44:06]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/michaelpg@chromium.org/376093002/40001

[commit-bot: I haz the power, 2014-07-15 19:18:39]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_chromium_gn_compile_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_c...)

[commit-bot: I haz the power, 2014-07-16 00:17:08]

Change committed as 283296