Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(943)

Unified Diff: pdf/pdf_engine.h

Issue 376083002: Export a function from the PDF plugin to get the dimensions of a PDF page. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Redid comments to conform to the style of existing comment. Rename parameters for same reason. Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pdf/pdf_engine.h
diff --git a/pdf/pdf_engine.h b/pdf/pdf_engine.h
index ee1cb1ff000341f1f0569dc1d617de11ee1260f5..24508a10cda413055d4d3315c1981d79c31b2bf0 100644
--- a/pdf/pdf_engine.h
+++ b/pdf/pdf_engine.h
@@ -308,10 +308,16 @@ class PDFEngineExports {
int page_number,
const RenderingSettings& settings,
void* bitmap_buffer) = 0;
+
virtual bool GetPDFDocInfo(const void* pdf_buffer,
int buffer_size,
int* page_count,
double* max_page_width) = 0;
+
+ // See the definition of GetPDFPageSizeByIndex in pdf.cc for details.
Dan Beam 2014/07/09 22:18:21 you should make the .cc file always adhere to the
ivandavid 2014/07/09 22:53:40 Done.
+ virtual bool GetPDFPageSizeByIndex(const void* pdf_buffer,
+ int pdf_buffer_size, int page_number,
+ double* width, double* height) = 0;
};
} // namespace chrome_pdf

Powered by Google App Engine
This is Rietveld 408576698