Export a function from the PDF plugin to get the dimensions of a PDF page.

pdf/pdfium/pdfium_engine.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "pdf/pdfium/pdfium_engine.h"
 
 #include <math.h>
 
 #include "base/json/json_writer.h"
 #include "base/logging.h"
@@ skipping 118 matching lines @@
 
 PP_Instance g_last_instance_id;
 
 struct PDFFontSubstitution {
   const char* pdf_name;
   const char* face;
   bool bold;
   bool italic;
 };
 
-PP_BrowserFont_Trusted_Weight WeightToBrowserFontTrustedWeight(int weight) {

[Lei Zhang, 2014/07/09 02:10:48]

Why is this code deleted?

-  COMPILE_ASSERT(PP_BROWSERFONT_TRUSTED_WEIGHT_100 == 0,
-                 PP_BrowserFont_Trusted_Weight_Min);
-  COMPILE_ASSERT(PP_BROWSERFONT_TRUSTED_WEIGHT_900 == 8,
-                 PP_BrowserFont_Trusted_Weight_Max);
-  const int kMinimumWeight = 100;
-  const int kMaximumWeight = 900;
-  int normalized_weight =
-      std::min(std::max(weight, kMinimumWeight), kMaximumWeight);
-  normalized_weight = (normalized_weight / 100) - 1;
-  return static_cast<PP_BrowserFont_Trusted_Weight>(normalized_weight);
-}
-
 // This list is for CPWL_FontMap::GetDefaultFontByCharset().
 // We pretend to have these font natively and let the browser (or underlying
 // fontconfig) to pick the proper font on the system.
 void EnumFonts(struct _FPDF_SYSFONTINFO* sysfontinfo, void* mapper) {
   FPDF_AddInstalledFont(mapper, "Arial", FXFONT_DEFAULT_CHARSET);
 
   int i = 0;
   while (CPWL_FontMap::defaultTTFMap[i].charset != -1) {
     FPDF_AddInstalledFont(mapper,
                           CPWL_FontMap::defaultTTFMap[i].fontname,
@@ skipping 65 matching lines @@
       if (PDFFontSubstitutions[i].italic)
         description.set_italic(true);
       break;
     }
   }
 
   if (i == arraysize(PDFFontSubstitutions)) {
     // TODO(kochi): Pass the face in UTF-8. If face is not encoded in UTF-8,
     // convert to UTF-8 before passing.
     description.set_face(face);
-
-    description.set_weight(WeightToBrowserFontTrustedWeight(weight));
-    description.set_italic(italic > 0);
   }
 
   if (!pp::PDF::IsAvailable()) {
     NOTREACHED();
     return NULL;
   }
 
   PP_Resource font_resource = pp::PDF::GetFontFileWithFallback(
       pp::InstanceHandle(g_last_instance_id),
       &description.pp_font_description(),
@@ skipping 3143 matching lines @@
       FPDF_GetPageSizeByIndex(doc, page_number, &page_width, &page_height);
       if (page_width > *max_page_width) {
         *max_page_width = page_width;
       }
     }
   }
   FPDF_CloseDocument(doc);
   return true;
 }
 
+bool PDFiumEngineExports::GetPDFPageSizeByIndex(
+    const void* pdf_buffer,
+    int buffer_size,
+    int index,
+    double* width,
+    double* height) {
+  FPDF_DOCUMENT doc = FPDF_LoadMemDocument(pdf_buffer, buffer_size, NULL);
+  bool success = false;

[Lei Zhang, 2014/07/09 02:10:48]

Can you try following my suggested pattern? There's no need to introduce a
variable here just yet. Just return false if |doc| is NULL. Declare |success| on
the first real use of |success|.

+  if (!doc)
+    return success;
+  success = FPDF_GetPageSizeByIndex(doc, index, width, height) != 0;
+  FPDF_CloseDocument(doc);
+  return success;
+}
+
 }  // namespace chrome_pdf