Issue 376043003: Revert commit 95c018e2d15ecc3a5bd2a9aab18638316a6d3d46

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 376043003: Revert commit 95c018e2d15ecc3a5bd2a9aab18638316a6d3d46 (Closed)

Created:
6 years, 5 months ago by Lei Zhang

Modified:
6 years, 5 months ago

Reviewers:
Peter Kasting

CC:
pdfium-reviews_googlegroups.com, aarya, palmer

Base URL:
https://pdfium.googlesource.com/pdfium.git@master

Visibility:
Public.

Revert commit 95c018e2d15ecc3a5bd2a9aab18638316a6d3d46 Fixes for re-enabling more MSVC level 4 warnings: pdfium/ edition BUG=81439 TBR=pkasting@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/ab99c38

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+26 lines, -6 lines)			Patch
M	core/include/fxcrt/fx_ucd.h	View	1 chunk	+14 lines, -0 lines	0 comments	Download
M	fpdfsdk/include/fpdfview.h	View	2 chunks	+7 lines, -2 lines	0 comments	Download
M	fpdfsdk/src/fpdfview.cpp	View	2 chunks	+4 lines, -3 lines	0 comments	Download
M	samples/pdfium_test.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 3 (0 generated)

Lei Zhang

Undo the last CL, so we can fix GN and roll DEPS for the security ...

6 years, 5 months ago (2014-07-08 23:55:29 UTC) #1

Lei Zhang

6 years, 5 months ago (2014-07-08 23:56:16 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as rab99c38 (presubmit successful).