editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ConstantVerifier.java - Issue 376043002: Report errors when an exception would occur during const fromEnvironment calls.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ConstantVerifier.java

Issue 376043002: Report errors when an exception would occur during const fromEnvironment calls. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Re-enable shared tests for dart2analyzer Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/constant/ConstantValueComputer.java ('k') | editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/CompileTimeErrorCodeTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ConstantVerifier.java

diff --git a/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ConstantVerifier.java b/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ConstantVerifier.java

index f3b9137a3b918942e590b5c5dddfa615ffffcc1d..7459a5f644faf18ae5c87c8881c3578cfdbf72bf 100644

--- a/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ConstantVerifier.java

+++ b/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ConstantVerifier.java

@@ -176,6 +176,9 @@ public class ConstantVerifier extends RecursiveAstVisitor<Void> {

@Override

public Void visitInstanceCreationExpression(InstanceCreationExpression node) {

+ if (node.isConst()) {

+ validate(node, null);

+ }

validateInstanceCreationArguments(node);

return super.visitInstanceCreationExpression(node);

}

@@ -416,7 +419,7 @@ public class ConstantVerifier extends RecursiveAstVisitor<Void> {

|| dataErrorCode == CompileTimeErrorCode.CONST_EVAL_TYPE_INT

|| dataErrorCode == CompileTimeErrorCode.CONST_EVAL_TYPE_NUM) {

errorReporter.reportErrorForNode(dataErrorCode, data.getNode());

- } else {

+ } else if (errorCode != null) {

errorReporter.reportErrorForNode(errorCode, data.getNode());

}