Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1422)

Unified Diff: chrome/browser/guest_view/web_view/web_view_guest.cc

Issue 376033002: Adding MimeHandlerView. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@pending-zork-patch2
Patch Set: remove some printfs. Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/guest_view/web_view/web_view_guest.cc
diff --git a/chrome/browser/guest_view/web_view/web_view_guest.cc b/chrome/browser/guest_view/web_view/web_view_guest.cc
index 77e367615c51027aa6a21383f67c42b61c567dbc..d15db55c6345c19190f6d71a58a8cca033608483 100644
--- a/chrome/browser/guest_view/web_view/web_view_guest.cc
+++ b/chrome/browser/guest_view/web_view/web_view_guest.cc
@@ -392,13 +392,20 @@ void WebViewGuest::CreateWebContents(
}
std::string url_encoded_partition = net::EscapeQueryParamValue(
storage_partition_id, false);
+ std::string emburl;
+ if (!create_params.GetString("emburl", &emburl)) {
+ emburl = embedder_extension_id;
+ } else {
+ printf("Found emburl: %s\n", emburl.c_str());
+ }
// The SiteInstance of a given webview tag is based on the fact that it's
// a guest process in addition to which platform application the tag
// belongs to and what storage partition is in use, rather than the URL
// that the tag is being navigated to.
GURL guest_site(base::StringPrintf("%s://%s/%s?%s",
content::kGuestScheme,
- embedder_extension_id.c_str(),
+ //embedder_extension_id.c_str(),
+ emburl.c_str(),
persist_storage ? "persist" : "",
url_encoded_partition.c_str()));
@@ -1082,6 +1089,7 @@ void WebViewGuest::DocumentLoadedInFrame(
bool WebViewGuest::OnMessageReceived(const IPC::Message& message,
RenderFrameHost* render_frame_host) {
bool handled = true;
+ printf("+++++ %s\n", __PRETTY_FUNCTION__);
IPC_BEGIN_MESSAGE_MAP(WebViewGuest, message)
IPC_MESSAGE_HANDLER(ChromeViewHostMsg_UpdateFrameName, OnUpdateFrameName)
IPC_MESSAGE_UNHANDLED(handled = false)
@@ -1153,7 +1161,7 @@ void WebViewGuest::PushWebViewStateToIOThread() {
NOTREACHED();
return;
}
- DCHECK(embedder_extension_id() == partition_domain);
+ //DCHECK(embedder_extension_id() == partition_domain);
WebViewRendererState::WebViewInfo web_view_info;
web_view_info.embedder_process_id = embedder_render_process_id();
@@ -1645,7 +1653,7 @@ void WebViewGuest::DestroyUnattachedWindows() {
GURL WebViewGuest::ResolveURL(const std::string& src) {
if (!in_extension()) {
- NOTREACHED();
+ //NOTREACHED();
return GURL(src);
}

Powered by Google App Engine
This is Rietveld 408576698