Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2279)

Unified Diff: chrome/browser/guest_view/guest_view_base.cc

Issue 376033002: Adding MimeHandlerView. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@pending-zork-patch2
Patch Set: remove some printfs. Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/guest_view/guest_view_base.cc
diff --git a/chrome/browser/guest_view/guest_view_base.cc b/chrome/browser/guest_view/guest_view_base.cc
index 2b335016103e3249da6db11bd06b7678623008e5..e30062021ef23876e135c97c0bb04872ef73aa97 100644
--- a/chrome/browser/guest_view/guest_view_base.cc
+++ b/chrome/browser/guest_view/guest_view_base.cc
@@ -10,6 +10,7 @@
#include "chrome/browser/guest_view/app_view/app_view_guest.h"
#include "chrome/browser/guest_view/guest_view_constants.h"
#include "chrome/browser/guest_view/guest_view_manager.h"
+#include "chrome/browser/guest_view/mime_handler_view/mime_handler_view_guest.h"
#include "chrome/browser/guest_view/web_view/web_view_guest.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/common/chrome_switches.h"
@@ -135,6 +136,10 @@ GuestViewBase* GuestViewBase::Create(
return NULL;
}
return new AppViewGuest(browser_context, guest_instance_id);
+ } else if (view_type == MimeHandlerViewGuest::Type) {
+ printf("++++ GuestViewBase::Create MimeHandlerViewGuest\n");
+ // TODO(lazyboy): Checks if we are allowed to create one.
+ return new MimeHandlerViewGuest(browser_context, guest_instance_id);
}
NOTREACHED();
return NULL;
@@ -305,7 +310,7 @@ GuestViewBase::~GuestViewBase() {
void GuestViewBase::DispatchEvent(Event* event) {
scoped_ptr<Event> event_ptr(event);
if (!in_extension()) {
- NOTREACHED();
+ //NOTREACHED();
Fady Samuel 2014/07/09 14:54:17 This shouldn't be causing problems. Why did you co
lazyboy 2014/07/10 04:11:00 Right, all changes in this file are leftover from
return;
}

Powered by Google App Engine
This is Rietveld 408576698