Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 376033002: Adding MimeHandlerView. (Closed)

Created:
6 years, 5 months ago by lazyboy
Modified:
6 years, 3 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, creis+watch_chromium.org, nasko+codewatch_chromium.org, jam, darin-cc_chromium.org, chromium-apps-reviews_chromium.org, stuartmorgan+watch_chromium.org, Zachary Kuznia
Base URL:
https://chromium.googlesource.com/chromium/src.git@pending-zork-patch2
Project:
chromium
Visibility:
Public.

Description

Adding MimeHandlerView. This GuestView type would be used to render out of process pdf through extension. This introduces BrowserPluginDelegate in content/renderer, because we need a way to create a MimeHandlerView guest (extensions/ concept) from BrowserPlugin (content/ concept). MimeHandlerView is behind --enable-mime-handler-view flag. BUG=303491 Test=Apply http://crrev.com/392813003/ on top of this CL, Launch chrome with --out-of-process-pdf flag and --enable-mime-handler-view flag Navigate to a PDF Check PDF is served using BrowserPlugin, probably easier to see process associated with the BrowserPlugin from Chrome's task manager. Committed: https://crrev.com/abce781d9bc37e60d95ed9504407169f845e056d Cr-Commit-Position: refs/heads/master@{#293613}

Patch Set 1 #

Patch Set 2 : remove some printfs. #

Total comments: 13

Patch Set 3 : address some comments from fady, more cleanups #

Patch Set 4 : revert more unnecessary changes #

Patch Set 5 : clean up some navigation code #

Patch Set 6 : fix retained problem #

Patch Set 7 : . #

Patch Set 8 : final set of cleanup for now #

Patch Set 9 : sync @tott #

Total comments: 20

Patch Set 10 : sync @tott #

Patch Set 11 : address comments from Fady #

Patch Set 12 : Put all MimeHandlerView /w same mime-type to same process #

Total comments: 2

Patch Set 13 : simplify guest URL #

Patch Set 14 : sync @r286925 #

Patch Set 15 : With the new attach approach #

Total comments: 32

Patch Set 16 : address comments #

Patch Set 17 : missed one comment #

Patch Set 18 : add (c) header #

Total comments: 24

Patch Set 19 : sync @tott #

Patch Set 20 : changes to make the CL compile #

Patch Set 21 : address comments from Fady #

Total comments: 10

Patch Set 22 : Move to /extensions, add constants file, git cl format #

Total comments: 8

Patch Set 23 : address comments #

Total comments: 12

Patch Set 24 : sync @tott #

Patch Set 25 : add switch to control feature, remove a DCHECK from extension_message_filter #

Total comments: 4

Patch Set 26 : Address comments, git cl format, some cleanup #

Patch Set 27 : s/delegate/delegate_ #

Patch Set 28 : Fix tests #

Patch Set 29 : reup #

Patch Set 30 : fix gn build #

Patch Set 31 : actually fix BUILD.gn this time #

Patch Set 32 : add mime_handler_view_guest_internal.json to fix ExtensionsApiTest.StubsApp #

Total comments: 2

Patch Set 33 : Address comment from kenrb@ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+529 lines, -58 lines) Patch
M chrome/browser/apps/web_view_interactive_browsertest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 2 chunks +1 line, -5 lines 0 comments Download
M chrome/chrome_renderer.gypi View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/common/extensions/api/_api_features.json View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 1 chunk +6 lines, -0 lines 0 comments Download
A chrome/renderer/browser_plugin/chrome_browser_plugin_delegate.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 1 chunk +39 lines, -0 lines 0 comments Download
A chrome/renderer/browser_plugin/chrome_browser_plugin_delegate.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 1 chunk +68 lines, -0 lines 0 comments Download
M chrome/renderer/chrome_content_renderer_client.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/renderer/chrome_content_renderer_client.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 2 chunks +8 lines, -0 lines 0 comments Download
M chrome/test/data/extensions/platform_apps/web_view/focus/inject_input_method.js View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 3 chunks +7 lines, -18 lines 0 comments Download
M content/content_renderer.gypi View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 1 chunk +1 line, -0 lines 0 comments Download
A content/public/renderer/browser_plugin_delegate.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 1 chunk +38 lines, -0 lines 0 comments Download
M content/public/renderer/content_renderer_client.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 2 chunks +6 lines, -0 lines 0 comments Download
M content/public/renderer/content_renderer_client.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 1 chunk +6 lines, -0 lines 0 comments Download
M content/renderer/browser_plugin/browser_plugin.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 4 chunks +4 lines, -4 lines 0 comments Download
M content/renderer/browser_plugin/browser_plugin.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 5 chunks +13 lines, -11 lines 0 comments Download
M content/renderer/browser_plugin/browser_plugin_manager.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 2 chunks +2 lines, -1 line 0 comments Download
M content/renderer/browser_plugin/browser_plugin_manager_impl.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/browser_plugin/browser_plugin_manager_impl.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 2 chunks +3 lines, -2 lines 0 comments Download
M content/renderer/browser_plugin/mock_browser_plugin.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/browser_plugin/mock_browser_plugin.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 1 chunk +4 lines, -2 lines 0 comments Download
M content/renderer/browser_plugin/mock_browser_plugin_manager.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 2 chunks +2 lines, -1 line 0 comments Download
M content/renderer/browser_plugin/mock_browser_plugin_manager.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 3 chunks +6 lines, -2 lines 0 comments Download
M extensions/browser/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 1 chunk +4 lines, -0 lines 0 comments Download
M extensions/browser/extension_message_filter.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 3 chunks +12 lines, -0 lines 0 comments Download
M extensions/browser/extension_message_filter.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 6 chunks +80 lines, -2 lines 0 comments Download
M extensions/browser/guest_view/guest_view_base.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 2 chunks +2 lines, -0 lines 0 comments Download
A extensions/browser/guest_view/mime_handler_view/mime_handler_view_constants.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 1 chunk +17 lines, -0 lines 0 comments Download
A extensions/browser/guest_view/mime_handler_view/mime_handler_view_constants.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 1 chunk +12 lines, -0 lines 0 comments Download
A extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 1 chunk +39 lines, -0 lines 0 comments Download
A extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 1 chunk +97 lines, -0 lines 0 comments Download
A + extensions/common/api/mime_handler_view_guest_internal.json View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 1 chunk +6 lines, -5 lines 0 comments Download
M extensions/common/api/schemas.gypi View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 1 chunk +1 line, -0 lines 0 comments Download
M extensions/common/extension_messages.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 2 chunks +11 lines, -0 lines 0 comments Download
M extensions/common/feature_switch.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 1 chunk +1 line, -0 lines 0 comments Download
M extensions/common/feature_switch.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 3 chunks +7 lines, -1 line 0 comments Download
M extensions/common/switches.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 2 chunks +2 lines, -0 lines 0 comments Download
M extensions/common/switches.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 2 chunks +7 lines, -0 lines 0 comments Download
M extensions/extensions.gyp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 1 chunk +4 lines, -0 lines 0 comments Download
M extensions/extensions_strings.grd View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 51 (10 generated)
Fady Samuel
Some initial thoughts. Sorry for the drive-by. I know this isn't quite ready for review. ...
6 years, 5 months ago (2014-07-09 14:54:18 UTC) #1
lazyboy
https://codereview.chromium.org/376033002/diff/20001/chrome/browser/extensions/url_request_util.cc File chrome/browser/extensions/url_request_util.cc (right): https://codereview.chromium.org/376033002/diff/20001/chrome/browser/extensions/url_request_util.cc#newcode140 chrome/browser/extensions/url_request_util.cc:140: return true; On 2014/07/09 14:54:17, Fady Samuel wrote: > ...
6 years, 5 months ago (2014-07-10 04:11:01 UTC) #2
Fady Samuel
https://codereview.chromium.org/376033002/diff/20001/chrome/browser/extensions/url_request_util.cc File chrome/browser/extensions/url_request_util.cc (right): https://codereview.chromium.org/376033002/diff/20001/chrome/browser/extensions/url_request_util.cc#newcode140 chrome/browser/extensions/url_request_util.cc:140: return true; On 2014/07/10 04:11:00, lazyboy wrote: > On ...
6 years, 5 months ago (2014-07-10 15:13:42 UTC) #3
Fady Samuel
Some more thoughts. https://codereview.chromium.org/376033002/diff/160001/chrome/browser/guest_view/mime_handler_view/mime_handler_view_guest.cc File chrome/browser/guest_view/mime_handler_view/mime_handler_view_guest.cc (right): https://codereview.chromium.org/376033002/diff/160001/chrome/browser/guest_view/mime_handler_view/mime_handler_view_guest.cc#newcode25 chrome/browser/guest_view/mime_handler_view/mime_handler_view_guest.cc:25: has_navigated_(false) { Get rid of this ...
6 years, 5 months ago (2014-07-21 14:47:35 UTC) #4
lazyboy
https://codereview.chromium.org/376033002/diff/160001/chrome/browser/guest_view/mime_handler_view/mime_handler_view_guest.cc File chrome/browser/guest_view/mime_handler_view/mime_handler_view_guest.cc (right): https://codereview.chromium.org/376033002/diff/160001/chrome/browser/guest_view/mime_handler_view/mime_handler_view_guest.cc#newcode25 chrome/browser/guest_view/mime_handler_view/mime_handler_view_guest.cc:25: has_navigated_(false) { On 2014/07/21 14:47:35, Fady Samuel wrote: > ...
6 years, 5 months ago (2014-07-21 17:28:21 UTC) #5
lazyboy
I've updated the CL (patchset #12) to put all MimeHandlerView-s /w same mime-type under same ...
6 years, 5 months ago (2014-07-22 00:04:44 UTC) #6
lazyboy
/cc Raymes/Zach. I've updated the CL (patchset #12) to put all MimeHandlerView-s /w same mime-type ...
6 years, 5 months ago (2014-07-22 00:05:54 UTC) #7
raymes
Thanks for your fast work!! I tested the patch and posted the results on the ...
6 years, 5 months ago (2014-07-22 08:07:54 UTC) #8
Fady Samuel
https://codereview.chromium.org/376033002/diff/220001/chrome/browser/guest_view/guest_view_manager.cc File chrome/browser/guest_view/guest_view_manager.cc (right): https://codereview.chromium.org/376033002/diff/220001/chrome/browser/guest_view/guest_view_manager.cc#newcode125 chrome/browser/guest_view/guest_view_manager.cc:125: bool has_mime_type_param = net::GetValueForKeyInQuery(guest_site, I don't understand this change. ...
6 years, 5 months ago (2014-07-22 10:59:49 UTC) #9
lazyboy
https://codereview.chromium.org/376033002/diff/220001/chrome/browser/guest_view/guest_view_manager.cc File chrome/browser/guest_view/guest_view_manager.cc (right): https://codereview.chromium.org/376033002/diff/220001/chrome/browser/guest_view/guest_view_manager.cc#newcode125 chrome/browser/guest_view/guest_view_manager.cc:125: bool has_mime_type_param = net::GetValueForKeyInQuery(guest_site, On 2014/07/22 10:59:49, Fady Samuel ...
6 years, 5 months ago (2014-07-22 20:32:56 UTC) #10
raymes
On 2014/07/22 20:32:56, lazyboy wrote: > https://codereview.chromium.org/376033002/diff/220001/chrome/browser/guest_view/guest_view_manager.cc > File chrome/browser/guest_view/guest_view_manager.cc (right): > > https://codereview.chromium.org/376033002/diff/220001/chrome/browser/guest_view/guest_view_manager.cc#newcode125 > ...
6 years, 4 months ago (2014-07-31 23:08:47 UTC) #11
lazyboy
On 2014/07/31 23:08:47, raymes wrote: > On 2014/07/22 20:32:56, lazyboy wrote: > > > https://codereview.chromium.org/376033002/diff/220001/chrome/browser/guest_view/guest_view_manager.cc ...
6 years, 4 months ago (2014-07-31 23:21:22 UTC) #12
lazyboy
I've rebased @tott fixing the merge conflict at patchset #14
6 years, 4 months ago (2014-08-01 01:56:58 UTC) #13
lazyboy
Rebased @tott and fixed merge conflicts [patchset #14]
6 years, 4 months ago (2014-08-01 01:57:37 UTC) #14
raymes
Hey Fady, Do you have any estimate on when we will be able to land ...
6 years, 4 months ago (2014-08-05 06:57:47 UTC) #15
Fady Samuel
On 2014/08/05 06:57:47, raymes wrote: > Hey Fady, > > Do you have any estimate ...
6 years, 4 months ago (2014-08-05 22:08:49 UTC) #16
Fady Samuel
On 2014/08/05 22:08:49, Fady Samuel wrote: > On 2014/08/05 06:57:47, raymes wrote: > > Hey ...
6 years, 4 months ago (2014-08-21 19:43:36 UTC) #17
raymes
No worries - that sounds good! Please keep me posted, we're currently blocked on this ...
6 years, 4 months ago (2014-08-22 00:31:36 UTC) #18
lazyboy
I've uploaded patchset #15 which uses the new attach approach. This introduces BrowserPluginDelegate on chrome/.
6 years, 3 months ago (2014-08-29 18:27:40 UTC) #19
Fady Samuel
A lot of comments are repeated but generally where the delegate is created is my ...
6 years, 3 months ago (2014-08-29 18:52:32 UTC) #20
lazyboy
Comments addressed in patchset #16, #17 Two major concerns addressed here: a. creating BPDelegate and ...
6 years, 3 months ago (2014-08-29 22:08:26 UTC) #21
Fady Samuel
https://codereview.chromium.org/376033002/diff/340001/chrome/browser/guest_view/mime_handler_view/mime_handler_view_guest.cc File chrome/browser/guest_view/mime_handler_view/mime_handler_view_guest.cc (right): https://codereview.chromium.org/376033002/diff/340001/chrome/browser/guest_view/mime_handler_view/mime_handler_view_guest.cc#newcode42 chrome/browser/guest_view/mime_handler_view/mime_handler_view_guest.cc:42: return "guestViewInternal"; You can create a new API namespace ...
6 years, 3 months ago (2014-09-02 15:08:25 UTC) #22
lazyboy
Comments addressed in patchset #21 https://chromiumcodereview.appspot.com/376033002/diff/340001/chrome/browser/guest_view/mime_handler_view/mime_handler_view_guest.cc File chrome/browser/guest_view/mime_handler_view/mime_handler_view_guest.cc (right): https://chromiumcodereview.appspot.com/376033002/diff/340001/chrome/browser/guest_view/mime_handler_view/mime_handler_view_guest.cc#newcode42 chrome/browser/guest_view/mime_handler_view/mime_handler_view_guest.cc:42: return "guestViewInternal"; On 2014/09/02 ...
6 years, 3 months ago (2014-09-02 20:17:22 UTC) #23
Fady Samuel
So this is pretty close to being where we need it to be I think. ...
6 years, 3 months ago (2014-09-02 20:30:01 UTC) #24
lazyboy
Comments addressed in patchset #22, includes: - Moved MimeHandlerViewGuest under /extensions - Did some polish, ...
6 years, 3 months ago (2014-09-02 21:44:23 UTC) #28
Fady Samuel
lgtm with nits https://chromiumcodereview.appspot.com/376033002/diff/480001/chrome/renderer/browser_plugin/chrome_browser_plugin_delegate.h File chrome/renderer/browser_plugin/chrome_browser_plugin_delegate.h (right): https://chromiumcodereview.appspot.com/376033002/diff/480001/chrome/renderer/browser_plugin/chrome_browser_plugin_delegate.h#newcode13 chrome/renderer/browser_plugin/chrome_browser_plugin_delegate.h:13: class ChromeBrowserPluginDelegate : public content::BrowserPluginDelegate, Perhaps ...
6 years, 3 months ago (2014-09-02 21:53:26 UTC) #29
lazyboy
https://chromiumcodereview.appspot.com/376033002/diff/480001/chrome/renderer/browser_plugin/chrome_browser_plugin_delegate.h File chrome/renderer/browser_plugin/chrome_browser_plugin_delegate.h (right): https://chromiumcodereview.appspot.com/376033002/diff/480001/chrome/renderer/browser_plugin/chrome_browser_plugin_delegate.h#newcode13 chrome/renderer/browser_plugin/chrome_browser_plugin_delegate.h:13: class ChromeBrowserPluginDelegate : public content::BrowserPluginDelegate, On 2014/09/02 21:53:25, Fady ...
6 years, 3 months ago (2014-09-02 22:03:20 UTC) #30
lazyboy
+John for content/public/renderer/browser_plugin_delegate.h content/public/renderer/content_renderer_client.h content/public/renderer/content_renderer_client.cc and Implementation of browser_plugin_delegate: chrome/renderer/browser_plugin/chrome_browser_plugin_delegate.h chrome/renderer/browser_plugin/chrome_browser_plugin_delegate.cc +Ken for everything under ...
6 years, 3 months ago (2014-09-02 22:51:49 UTC) #32
jam
lgtm https://codereview.chromium.org/376033002/diff/500001/content/public/renderer/content_renderer_client.h File content/public/renderer/content_renderer_client.h (right): https://codereview.chromium.org/376033002/diff/500001/content/public/renderer/content_renderer_client.h#newcode105 content/public/renderer/content_renderer_client.h:105: virtual BrowserPluginDelegate* CreateBrowserPluginDelegate( nit: every other method in ...
6 years, 3 months ago (2014-09-03 21:55:52 UTC) #33
Ken Rockot(use gerrit already)
lgtm https://codereview.chromium.org/376033002/diff/500001/chrome/renderer/browser_plugin/chrome_browser_plugin_delegate.cc File chrome/renderer/browser_plugin/chrome_browser_plugin_delegate.cc (right): https://codereview.chromium.org/376033002/diff/500001/chrome/renderer/browser_plugin/chrome_browser_plugin_delegate.cc#newcode56 chrome/renderer/browser_plugin/chrome_browser_plugin_delegate.cc:56: IPC_MESSAGE_HANDLER(ExtensionMsg_CreateMimeHandlerViewGuestACK, nit: ugh. clang_format wants to unindent these ...
6 years, 3 months ago (2014-09-04 00:57:43 UTC) #34
lazyboy
Fady, can you take a look at the flag/switch changes (patchset #24 -> @25), I've ...
6 years, 3 months ago (2014-09-04 17:25:21 UTC) #35
Fady Samuel
lgtm with nits https://chromiumcodereview.appspot.com/376033002/diff/540001/chrome/test/data/extensions/platform_apps/web_view/focus/inject_input_method.js File chrome/test/data/extensions/platform_apps/web_view/focus/inject_input_method.js (right): https://chromiumcodereview.appspot.com/376033002/diff/540001/chrome/test/data/extensions/platform_apps/web_view/focus/inject_input_method.js#newcode18 chrome/test/data/extensions/platform_apps/web_view/focus/inject_input_method.js:18: var waitingForInput = false; Why is ...
6 years, 3 months ago (2014-09-04 17:31:07 UTC) #36
lazyboy
Addressed all pending nits. +kenrb for IPC security review for 2 added IPCs: extensions/common/extension_messages.h https://chromiumcodereview.appspot.com/376033002/diff/500001/chrome/renderer/browser_plugin/chrome_browser_plugin_delegate.cc ...
6 years, 3 months ago (2014-09-04 18:59:34 UTC) #38
kenrb
ipc lgtm with a nit https://chromiumcodereview.appspot.com/376033002/diff/680001/extensions/common/extension_messages.h File extensions/common/extension_messages.h (right): https://chromiumcodereview.appspot.com/376033002/diff/680001/extensions/common/extension_messages.h#newcode744 extensions/common/extension_messages.h:744: // The ACK for ...
6 years, 3 months ago (2014-09-05 15:29:45 UTC) #39
lazyboy
Comment addressed in patchset #33 https://chromiumcodereview.appspot.com/376033002/diff/680001/extensions/common/extension_messages.h File extensions/common/extension_messages.h (right): https://chromiumcodereview.appspot.com/376033002/diff/680001/extensions/common/extension_messages.h#newcode744 extensions/common/extension_messages.h:744: // The ACK for ...
6 years, 3 months ago (2014-09-05 19:18:25 UTC) #40
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lazyboy@chromium.org/376033002/700001
6 years, 3 months ago (2014-09-05 22:30:38 UTC) #42
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lazyboy@chromium.org/376033002/700001
6 years, 3 months ago (2014-09-06 03:33:37 UTC) #45
commit-bot: I haz the power
Exceeded time limit waiting for builds to trigger.
6 years, 3 months ago (2014-09-06 10:37:20 UTC) #47
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lazyboy@chromium.org/376033002/700001
6 years, 3 months ago (2014-09-06 13:20:38 UTC) #49
commit-bot: I haz the power
Committed patchset #33 (id:700001) as 6b84f802a54ac60924a017b32823c4932db7c765
6 years, 3 months ago (2014-09-06 13:23:45 UTC) #50
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:42:28 UTC) #51
Message was sent while issue was closed.
Patchset 33 (id:??) landed as
https://crrev.com/abce781d9bc37e60d95ed9504407169f845e056d
Cr-Commit-Position: refs/heads/master@{#293613}

Powered by Google App Engine
This is Rietveld 408576698