Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 376023002: Mojo: Mojom parser: Make |module| use an |identifier_wrapped|. (Closed)

Created:
6 years, 5 months ago by viettrungluu
Modified:
6 years, 5 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Project:
chromium
Visibility:
Public.

Description

Mojo: Mojom parser: Make |module| use an |identifier_wrapped|. We should really get rid of the plain |identifier|, rename |identifier_wrapped| to |identifier|, and make that rule produce an ast.Identifier (say). But that change will be more involved. R=darin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281963

Patch Set 1 #

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -35 lines) Patch
M mojo/public/tools/bindings/pylib/mojom/parse/parser.py View 1 3 chunks +5 lines, -3 lines 0 comments Download
M mojo/public/tools/bindings/pylib/mojom/parse/translate.py View 1 2 chunks +13 lines, -12 lines 0 comments Download
M mojo/public/tools/bindings/pylib/mojom_tests/parse/parser_unittest.py View 1 17 chunks +20 lines, -20 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
viettrungluu
6 years, 5 months ago (2014-07-08 22:06:19 UTC) #1
darin (slow to review)
OK, LGTM
6 years, 5 months ago (2014-07-08 22:09:35 UTC) #2
viettrungluu
The CQ bit was checked by viettrungluu@chromium.org
6 years, 5 months ago (2014-07-09 00:42:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/viettrungluu@chromium.org/376023002/20001
6 years, 5 months ago (2014-07-09 00:44:14 UTC) #4
commit-bot: I haz the power
6 years, 5 months ago (2014-07-09 05:51:03 UTC) #5
Message was sent while issue was closed.
Change committed as 281963

Powered by Google App Engine
This is Rietveld 408576698