Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(799)

Issue 376022: DevTools: concatenate JS files into one big devtools.js file (similar to inspector.js in WebKit) (Closed)

Created:
11 years, 1 month ago by mnaganov (inactive)
Modified:
9 years, 7 months ago
Reviewers:
yurys, pfeldman
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

DevTools: concatenate JS files into one big devtools.js file (similar to inspector.js in WebKit) To use old-style unconcatenated sources, set 'debug_devtools' variable. BUG=26911 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=31782

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fixed long lines #

Unified diffs Side-by-side diffs Delta from patch set Stats (+105 lines, -4 lines) Patch
A webkit/build/concatenate_js_files.py View 1 1 chunk +64 lines, -0 lines 0 comments Download
M webkit/webkit_glue.gyp View 3 chunks +41 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
mnaganov (inactive)
11 years, 1 month ago (2009-11-09 16:37:29 UTC) #1
mnaganov (inactive)
On 2009/11/09 16:37:29, Michail Naganov wrote: > I tried to create a target for copying ...
11 years, 1 month ago (2009-11-09 16:46:38 UTC) #2
yurys
LGTM http://codereview.chromium.org/376022/diff/1/2 File webkit/build/concatenate_js_files.py (right): http://codereview.chromium.org/376022/diff/1/2#newcode25 Line 25: if 'type' in attrs_dict and attrs_dict['type'] == ...
11 years, 1 month ago (2009-11-12 10:14:52 UTC) #3
mnaganov (inactive)
11 years, 1 month ago (2009-11-12 10:25:27 UTC) #4
http://codereview.chromium.org/376022/diff/1/2
File webkit/build/concatenate_js_files.py (right):

http://codereview.chromium.org/376022/diff/1/2#newcode25
Line 25: if 'type' in attrs_dict and attrs_dict['type'] == 'text/javascript' and
'src' in attrs_dict:
On 2009/11/12 10:14:52, Yury Semikhatsky wrote:
> long line here and below

Done.

Powered by Google App Engine
This is Rietveld 408576698