Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 376014: Reland Extension Installed InfoBubble (Closed)

Created:
11 years, 1 month ago by rafaelw
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Reland Extension Installed InfoBubble (fix mac build breakage) This creates UI feedback upon successful installation of an extension. An InfoBubble is shown containing the install icon and some information about how to manage extensions. TEST=Install a packaged extension. Verify the InfoBubble is shown, with the install icon and some description. The InfoBubble should disappear when the bubble looses focus (click elsewhere). For a browserAction, the bubble should point to the browserAction icon. For a pageAction **that has a "default_icon" set in it's manifest (see the samples/subscribe_page_action in this CL)**, it should point to a temporarily shown pageAction icon that will be hidden when the bubble closes. Otherwise it should point to the wrench menu. BUG=21412 TBR=willchan Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=31365

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+482 lines, -59 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +13 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extension_install_ui.h View 4 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_install_ui.cc View 2 chunks +22 lines, -3 lines 0 comments Download
M chrome/browser/views/browser_actions_container.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/views/browser_actions_container.cc View 1 chunk +12 lines, -0 lines 0 comments Download
A chrome/browser/views/extensions/extension_installed_bubble.h View 1 chunk +81 lines, -0 lines 0 comments Download
A chrome/browser/views/extensions/extension_installed_bubble.cc View 1 chunk +229 lines, -0 lines 0 comments Download
M chrome/browser/views/info_bubble.h View 2 chunks +13 lines, -3 lines 0 comments Download
M chrome/browser/views/info_bubble.cc View 7 chunks +21 lines, -16 lines 0 comments Download
M chrome/browser/views/location_bar_view.h View 3 chunks +19 lines, -0 lines 0 comments Download
M chrome/browser/views/location_bar_view.cc View 3 chunks +34 lines, -2 lines 0 comments Download
M chrome/chrome.gyp View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/common/extensions/docs/static/pageAction.html View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/test/data/extensions/samples/subscribe_page_action/background.html View 2 chunks +19 lines, -28 lines 0 comments Download
M chrome/test/data/extensions/samples/subscribe_page_action/manifest.json View 1 chunk +2 lines, -5 lines 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698