Issue 375993002: Mojo: Mojom: Make enum values only integers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 375993002: Mojo: Mojom: Make enum values only integers. (Closed)

Created:
6 years, 5 months ago by viettrungluu

Modified:
6 years, 5 months ago

Reviewers:
darin (slow to review)

CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Mojo: Mojom: Make enum values only integers. Also require the list of values to be nonempty and add tests. R=darin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281856

Patch Set 1 #

Patch Set 2 : gah, we need (?) to allow enum value names as values #

Patch Set 3 : rebased #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+91 lines, -47 lines)			Patch
M	mojo/public/tools/bindings/pylib/mojom/parse/parser.py	View	1 2	2 chunks	+30 lines, -25 lines	0 comments	Download
M	mojo/public/tools/bindings/pylib/mojom/parse/translate.py	View	1 2	2 chunks	+5 lines, -5 lines	0 comments	Download
M	mojo/public/tools/bindings/pylib/mojom_tests/parse/parser_unittest.py	View	1 2	3 chunks	+56 lines, -17 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

viettrungluu

6 years, 5 months ago (2014-07-08 22:49:29 UTC) #3

Message was sent while issue was closed.

Committed patchset #3 manually as r281856 (presubmit successful).

Expand Messages | Collapse Messages