Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(927)

Unified Diff: chrome/browser/component_updater/update_checker.cc

Issue 375973003: Componentize component_updater: Use Configurator to build query parameters. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/component_updater/test/test_configurator.cc ('k') | chrome/chrome_browser.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/component_updater/update_checker.cc
diff --git a/chrome/browser/component_updater/update_checker.cc b/chrome/browser/component_updater/update_checker.cc
index 2a030128b0d3cdc35eeed855bb9a32687424ee8f..7fa828be2fadaf11b694d9352f03da70aff954a2 100644
--- a/chrome/browser/component_updater/update_checker.cc
+++ b/chrome/browser/component_updater/update_checker.cc
@@ -33,7 +33,8 @@ namespace component_updater {
// <package fp="abcd" />
// </packages>
// </app>
-std::string BuildUpdateCheckRequest(const std::vector<CrxUpdateItem*>& items,
+std::string BuildUpdateCheckRequest(const Configurator& config,
+ const std::vector<CrxUpdateItem*>& items,
const std::string& additional_attributes) {
std::string app_elements;
for (size_t i = 0; i != items.size(); ++i) {
@@ -59,7 +60,12 @@ std::string BuildUpdateCheckRequest(const std::vector<CrxUpdateItem*>& items,
VLOG(1) << "Appending to update request: " << app;
}
- return BuildProtocolRequest(app_elements, additional_attributes);
+ return BuildProtocolRequest(config.GetBrowserVersion().GetString(),
+ config.GetChannel(),
+ config.GetLang(),
+ config.GetOSLongName(),
+ app_elements,
+ additional_attributes);
}
class UpdateCheckerImpl : public UpdateChecker, public net::URLFetcherDelegate {
@@ -114,7 +120,7 @@ bool UpdateCheckerImpl::CheckForUpdates(
url_fetcher_.reset(SendProtocolRequest(
config_.UpdateUrl(),
- BuildUpdateCheckRequest(items_to_check, additional_attributes),
+ BuildUpdateCheckRequest(config_, items_to_check, additional_attributes),
this,
config_.RequestContext()));
« no previous file with comments | « chrome/browser/component_updater/test/test_configurator.cc ('k') | chrome/chrome_browser.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698