Componentize component_updater: Use Configurator to build query parameters.

chrome/browser/component_updater/component_updater_configurator.h

Index: chrome/browser/component_updater/component_updater_configurator.h
diff --git a/chrome/browser/component_updater/component_updater_configurator.h b/chrome/browser/component_updater/component_updater_configurator.h
index 9cb73bd836083bf9251f943994185d4df7d07d3b..72e51a0d1e557c6bc1aa6db861a82c706f2ccbe6 100644
--- a/chrome/browser/component_updater/component_updater_configurator.h
+++ b/chrome/browser/component_updater/component_updater_configurator.h
@@ -11,6 +11,7 @@ class GURL;
 
 namespace base {
 class CommandLine;
+class Version;
 }
 
 namespace net {
@@ -53,6 +54,21 @@ class Configurator {
   // pings are disabled.
   virtual GURL PingUrl() const = 0;
 
+  // Version of the application. Used to compare to component manifests.

[Sorin Jianu, 2014/07/10 12:27:28]

s/to/the ?

[Sorin Jianu, 2014/07/10 12:27:28]

Is the ApplicationVersion actually the Chrome browser version? If yes, maybe we
could be more specific here.

[tommycli, 2014/07/10 16:08:13]

Done.

[tommycli, 2014/07/10 16:08:13]

Done.

+  virtual base::Version ApplicationVersion() const = 0;
+
+  // Returns the value we use for the "updaterchannel=" and "prodchannel="
+  // parameters. Possible return values include: "canary", "dev", "beta", and
+  // "stable".
+  virtual std::string GetChannelString() const = 0;
+
+  // Returns the language for the present locale. Possible return values are
+  // standard tags for languages, such as "en", "en-US", "de", "fr", "af", etc.
+  virtual std::string GetLang() const = 0;
+
+  // Returns the OS's long name like "Windows", "Mac OS X", etc.
+  virtual std::string GetOSLongName() const = 0;
+
   // Parameters added to each url request. It can be empty if none are needed.
   // The return string must be safe for insertion as an attribute in an
   // XML element.