Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(510)

Side by Side Diff: chrome/common_constants.gyp

Issue 375973003: Componentize component_updater: Use Configurator to build query parameters. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix one gyp omission Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 { 5 {
6 'variables': { 6 'variables': {
7 'chromium_code': 1, 7 'chromium_code': 1,
8 }, 8 },
9 9
10 'includes': [ 10 'includes': [
(...skipping 54 matching lines...) Expand 10 before | Expand all | Expand 10 after
65 # GN version: //chrome/common:constants 65 # GN version: //chrome/common:constants
66 'target_name': 'common_constants', 66 'target_name': 'common_constants',
67 'type': 'static_library', 67 'type': 'static_library',
68 'include_dirs': [ 68 'include_dirs': [
69 '<(SHARED_INTERMEDIATE_DIR)', # Needed by chrome_paths.cc. 69 '<(SHARED_INTERMEDIATE_DIR)', # Needed by chrome_paths.cc.
70 ], 70 ],
71 'dependencies': [ 71 'dependencies': [
72 '../base/base.gyp:base', 72 '../base/base.gyp:base',
73 '../base/third_party/dynamic_annotations/dynamic_annotations.gyp:dynamic _annotations', 73 '../base/third_party/dynamic_annotations/dynamic_annotations.gyp:dynamic _annotations',
74 '../components/components.gyp:bookmarks_common', 74 '../components/components.gyp:bookmarks_common',
75 '../components/components.gyp:component_updater',
75 '../components/nacl.gyp:nacl_switches', 76 '../components/nacl.gyp:nacl_switches',
76 '../third_party/widevine/cdm/widevine_cdm.gyp:widevine_cdm_version_h', 77 '../third_party/widevine/cdm/widevine_cdm.gyp:widevine_cdm_version_h',
77 ], 78 ],
78 'target_conditions': [ 79 'target_conditions': [
79 ['OS=="ios"', { 80 ['OS=="ios"', {
80 # iOS needs chrome_paths_mac, which is excluded by filename rules; 81 # iOS needs chrome_paths_mac, which is excluded by filename rules;
81 # re-add it in target_conditionals so it's after that exclusion. 82 # re-add it in target_conditionals so it's after that exclusion.
82 'sources/': [ 83 'sources/': [
83 ['include', '^common/chrome_paths_mac\\.mm$'], 84 ['include', '^common/chrome_paths_mac\\.mm$'],
84 ], 85 ],
(...skipping 23 matching lines...) Expand all
108 'configurations': { 109 'configurations': {
109 'Common_Base': { 110 'Common_Base': {
110 'msvs_target_platform': 'x64', 111 'msvs_target_platform': 'x64',
111 }, 112 },
112 }, 113 },
113 }, 114 },
114 ], 115 ],
115 }], 116 }],
116 ], 117 ],
117 } 118 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698