Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(834)

Issue 375973002: Allow provision_devices to work on the L-release preview. (Closed)

Created:
6 years, 5 months ago by tonyg
Modified:
6 years, 5 months ago
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Allow provision_devices to work on the L-release preview. We weren't respecting the full timeout specified by the Reboot() method. And apparently timing is different enough on the L-release preview that reboots get stuck forever without the timeout. BUG=389362 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281927

Patch Set 1 #

Total comments: 4

Patch Set 2 : jbudorick comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -5 lines) Patch
M build/android/pylib/android_commands.py View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/android_testrunner/README.chromium View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/android_testrunner/adb_interface.py View 1 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
tonyg
6 years, 5 months ago (2014-07-08 19:40:30 UTC) #1
jbudorick
Thankfully, we won't have to deal with android_testrunner for much longer... https://codereview.chromium.org/375973002/diff/1/third_party/android_testrunner/adb_interface.py File third_party/android_testrunner/adb_interface.py (right): ...
6 years, 5 months ago (2014-07-08 20:00:45 UTC) #2
tonyg
https://codereview.chromium.org/375973002/diff/1/third_party/android_testrunner/adb_interface.py File third_party/android_testrunner/adb_interface.py (right): https://codereview.chromium.org/375973002/diff/1/third_party/android_testrunner/adb_interface.py#newcode321 third_party/android_testrunner/adb_interface.py:321: self.SendCommand("wait-for-device") On 2014/07/08 20:00:45, jbudorick wrote: > I think ...
6 years, 5 months ago (2014-07-08 20:17:11 UTC) #3
jbudorick
lgtm
6 years, 5 months ago (2014-07-08 20:44:38 UTC) #4
tonyg
The CQ bit was checked by tonyg@chromium.org
6 years, 5 months ago (2014-07-08 21:01:32 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tonyg@chromium.org/375973002/20001
6 years, 5 months ago (2014-07-08 21:03:30 UTC) #6
frankf
lgtm
6 years, 5 months ago (2014-07-08 23:54:56 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium ...
6 years, 5 months ago (2014-07-09 01:03:44 UTC) #8
commit-bot: I haz the power
6 years, 5 months ago (2014-07-09 04:25:42 UTC) #9
Message was sent while issue was closed.
Change committed as 281927

Powered by Google App Engine
This is Rietveld 408576698