Issue 375943002: Fixed up SkTimedPicturePlayback

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 375943002: Fixed up SkTimedPicturePlayback (Closed)

Created:
6 years, 5 months ago by robertphillips

Modified:
6 years, 5 months ago

Reviewers:
mtklein, reed1

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

Fixed up SkTimedPicturePlayback This was more motivated to remove the preDraw and postDraw virtuals from SkPicturePlayback. Committed: https://skia.googlesource.com/skia/+/92432c7f7c0a878256f139ce6f73d71e1c202a16

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+49 lines, -28 lines)			Patch
M	debugger/QT/SkDebuggerGUI.cpp	View	6 chunks	+48 lines, -7 lines	0 comments	Download
M	src/core/SkPicturePlayback.h	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	src/core/SkPicturePlayback.cpp	View	3 chunks	+0 lines, -15 lines	0 comments	Download
M	src/core/SkPictureRangePlayback.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 5 (0 generated)

robertphillips

The CQ bit was checked by robertphillips@google.com

6 years, 5 months ago (2014-07-08 19:34:45 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/robertphillips@google.com/375943002/1

6 years, 5 months ago (2014-07-08 19:35:07 UTC) #4

commit-bot: I haz the power

6 years, 5 months ago (2014-07-08 20:08:00 UTC) #5

Message was sent while issue was closed.

Change committed as 92432c7f7c0a878256f139ce6f73d71e1c202a16