Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(550)

Issue 375933002: Remove cloud policy refresh rate limit. (Closed)

Created:
6 years, 5 months ago by Steve Condie
Modified:
6 years, 5 months ago
Reviewers:
Joao da Silva
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove cloud policy refresh rate limit. BUG=391902 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282565

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -277 lines) Patch
M components/components_tests.gyp View 1 1 chunk +0 lines, -1 line 0 comments Download
M components/policy/core/common/BUILD.gn View 1 1 chunk +0 lines, -2 lines 0 comments Download
M components/policy/core/common/cloud/cloud_policy_refresh_scheduler.h View 1 3 chunks +1 line, -6 lines 0 comments Download
M components/policy/core/common/cloud/cloud_policy_refresh_scheduler.cc View 3 chunks +1 line, -16 lines 0 comments Download
M components/policy/core/common/cloud/cloud_policy_refresh_scheduler_unittest.cc View 1 chunk +3 lines, -11 lines 0 comments Download
D components/policy/core/common/cloud/rate_limiter.h View 1 1 chunk +0 lines, -60 lines 0 comments Download
D components/policy/core/common/cloud/rate_limiter.cc View 1 1 chunk +0 lines, -58 lines 0 comments Download
D components/policy/core/common/cloud/rate_limiter_unittest.cc View 1 1 chunk +0 lines, -121 lines 0 comments Download
M components/policy/policy_common.gypi View 1 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
Steve Condie
6 years, 5 months ago (2014-07-08 18:15:30 UTC) #1
Joao da Silva
https://codereview.chromium.org/375933002/diff/1/components/policy/core/common/cloud/cloud_policy_refresh_scheduler.h File components/policy/core/common/cloud/cloud_policy_refresh_scheduler.h (left): https://codereview.chromium.org/375933002/diff/1/components/policy/core/common/cloud/cloud_policy_refresh_scheduler.h#oldcode14 components/policy/core/common/cloud/cloud_policy_refresh_scheduler.h:14: #include "components/policy/core/common/cloud/rate_limiter.h" Delete this file and its .cc, no ...
6 years, 5 months ago (2014-07-09 12:12:51 UTC) #2
Steve Condie
https://codereview.chromium.org/375933002/diff/1/components/policy/core/common/cloud/cloud_policy_refresh_scheduler.h File components/policy/core/common/cloud/cloud_policy_refresh_scheduler.h (left): https://codereview.chromium.org/375933002/diff/1/components/policy/core/common/cloud/cloud_policy_refresh_scheduler.h#oldcode14 components/policy/core/common/cloud/cloud_policy_refresh_scheduler.h:14: #include "components/policy/core/common/cloud/rate_limiter.h" On 2014/07/09 12:12:51, Joao da Silva wrote: ...
6 years, 5 months ago (2014-07-09 17:39:01 UTC) #3
Joao da Silva
lgtm
6 years, 5 months ago (2014-07-10 12:06:27 UTC) #4
Steve Condie
The CQ bit was checked by stepco@chromium.org
6 years, 5 months ago (2014-07-10 17:24:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stepco@chromium.org/375933002/20001
6 years, 5 months ago (2014-07-10 17:25:39 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 5 months ago (2014-07-10 19:19:27 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-10 20:38:51 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/builds/47797)
6 years, 5 months ago (2014-07-10 20:38:52 UTC) #9
Steve Condie
The CQ bit was checked by stepco@chromium.org
6 years, 5 months ago (2014-07-11 00:31:32 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stepco@chromium.org/375933002/20001
6 years, 5 months ago (2014-07-11 00:33:52 UTC) #11
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_chromium_rel on tryserver.chromium ...
6 years, 5 months ago (2014-07-11 05:12:53 UTC) #12
commit-bot: I haz the power
6 years, 5 months ago (2014-07-11 07:03:10 UTC) #13
Message was sent while issue was closed.
Change committed as 282565

Powered by Google App Engine
This is Rietveld 408576698