Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(5)

Issue 37593002: Split up SkXfermode::asNewEffectOrCoeff() into asNewEffect(), asCoeff(). (Closed)

Created:
5 years, 7 months ago by Stephen White
Modified:
5 years, 7 months ago
Reviewers:
bsalomon
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Split up SkXfermode::asNewEffectOrCoeff() into asNewEffect(), asCoeff(). R=bsalomon@google.com Committed: https://code.google.com/p/skia/source/detail?r=11926

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -36 lines) Patch
M include/core/SkXfermode.h View 1 chunk +12 lines, -17 lines 0 comments Download
src/core/SkXfermode.cpp View 3 chunks +7 lines, -10 lines 0 comments Download
M src/core/SkXfermode_proccoeff.h View 1 chunk +2 lines, -4 lines 0 comments Download
M src/effects/SkArithmeticMode.cpp View 2 chunks +2 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Stephen White
Brian: PTAL. Thanks!
5 years, 7 months ago (2013-10-23 17:49:14 UTC) #1
bsalomon
lgtm
5 years, 7 months ago (2013-10-23 18:27:54 UTC) #2
Stephen White
5 years, 7 months ago (2013-10-23 18:41:42 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r11926 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698