Chromium Code Reviews Chromium Code Reviews
Issue
375923005:
cc: Explicitly invalidate all dropped recordings on the main thread. (Closed)
Descriptioncc: Explicitly invalidate all dropped recordings on the main thread.
Currently PictureLayerTiling drops tiles when bounds change under the
assumption that these recordings have been dropped by the main thread,
however it misses some cases. For instance if the layer grows, and the
main thread has to drop recording tiles along the growing edge, but it
is outside the interest rect, then the PictureLayerTiling has no idea
that these recordings are gone, which leads to us having Tiles on the
compositor thread which can not be rastered.
Instead of having the impl side try to guess at these things, we now
have the PicturePile explicitly expand invalidation to cover every
recoding tile that has its picture dropped or that is removed from the
recording. Then the impl-side PictureLayerTiling only drops what the
main thread tells it to, and does not make any guesses of its own.
Perf sheriffs: This is expected to change results for "invalidation"
tests as it changes what code paths those tests execute.
R=enne
BUG=386998
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282744
Patch Set 1 : invalid-resize: . #Patch Set 2 : invalid-resize: . #
Total comments: 1
Patch Set 3 : invalid-resize: . #
Total comments: 15
Patch Set 4 : invalid-resize: reviewd #Patch Set 5 : invalid-resize: extradcheck #Patch Set 6 : invalid-resize: doublecall #
Total comments: 3
Patch Set 7 : invalid-resize: nowwithmoreinvalidation #Patch Set 8 : invalid-resize: rebase #Patch Set 9 : invalid-resize: fixperftestcompile #Patch Set 10 : invalid-resize: resizedeletestiles #
Messages
Total messages: 12 (0 generated)
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
