LayoutTests/svg/custom/image-svgload-after-docload.html - Issue 375923002: Don't dispatch '(SVG)load' to ancestors of <svg:image> after doc. 'load'

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/svg/custom/image-svgload-after-docload.html

Issue 375923002: Don't dispatch '(SVG)load' to ancestors of <svg:image> after doc. 'load' (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Recursion-based sendSVG...AncestorChain...; Additional tests. Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script src="../../resources/testharness.js"></script>

	3 <script src="../../resources/testharnessreport.js"></script>

	4 <svg></svg>

	5 <script>

	6 var t = async_test("No 'load' is fired on the SVG root when an image is inserted into it.");

	7

	8 window.onload = function() {

	9 var svgRoot = document.querySelector('svg');

	10 svgRoot.onload = t.unreached_func("'load' should not fire on the SVG root.");

	11

	12 var image = document.createElementNS('http://www.w3.org/2000/svg', 'image');

	13 image.setAttributeNS('http://www.w3.org/1999/xlink', 'xlink:href', 'resources/ red-checker.png');

	14 image.setAttribute('width', 10);

	15 image.setAttribute('height', 10);

	16 image.onload = t.step_func(function() {

	17 assert_true(true);

	18 setTimeout(function() { t.done(); }, 0);
	pdr. 2014/07/10 03:48:15 I don't think this setTimeout is needed, nor the a I don't think this setTimeout is needed, nor the assert_true(true). fs 2014/07/10 08:32:50 The setTimeout is needed to provide a "window" for Show quoted text On 2014/07/10 03:48:15, pdr wrote: > I don't think this setTimeout is needed, nor the assert_true(true). The setTimeout is needed to provide a "window" for the <svg> load to be fired (which will be after the <image> load, but still within the same "task"). (I.e. without the setTimeout the test will pass without the fix.) The assert_true can certainly be dropped.
	19 });

	20 svgRoot.appendChild(image);

	21 }

	22 </script>

OLD	NEW