Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(542)

Unified Diff: components/policy/core/common/cloud/cloud_policy_constants.h

Issue 375903002: Fix EnterpriseDeviceManagementStatus UMA enum, add comments. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Cosmetics. Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/policy/core/common/cloud/enterprise_metrics.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/policy/core/common/cloud/cloud_policy_constants.h
diff --git a/components/policy/core/common/cloud/cloud_policy_constants.h b/components/policy/core/common/cloud/cloud_policy_constants.h
index f2c45696935d7cc37ffb50c763c3e2ee7dc7d2f4..b43d6bcf35cf35e3b4d9e227fbc8479aa68cd56d 100644
--- a/components/policy/core/common/cloud/cloud_policy_constants.h
+++ b/components/policy/core/common/cloud/cloud_policy_constants.h
@@ -69,37 +69,41 @@ enum UserAffiliation {
};
// Status codes for communication errors with the device management service.
+// This enum is used to define the buckets for an enumerated UMA histogram.
+// Hence,
+// (a) existing enumerated constants should never be deleted or reordered, and
+// (b) new constants should only be appended at the end of the enumeration.
enum DeviceManagementStatus {
// All is good.
- DM_STATUS_SUCCESS,
+ DM_STATUS_SUCCESS = 0,
// Request payload invalid.
- DM_STATUS_REQUEST_INVALID,
+ DM_STATUS_REQUEST_INVALID = 1,
// The HTTP request failed.
- DM_STATUS_REQUEST_FAILED,
+ DM_STATUS_REQUEST_FAILED = 2,
// The server returned an error code that points to a temporary problem.
- DM_STATUS_TEMPORARY_UNAVAILABLE,
+ DM_STATUS_TEMPORARY_UNAVAILABLE = 3,
// The HTTP request returned a non-success code.
- DM_STATUS_HTTP_STATUS_ERROR,
+ DM_STATUS_HTTP_STATUS_ERROR = 4,
// Response could not be decoded.
- DM_STATUS_RESPONSE_DECODING_ERROR,
+ DM_STATUS_RESPONSE_DECODING_ERROR = 5,
// Service error: Management not supported.
- DM_STATUS_SERVICE_MANAGEMENT_NOT_SUPPORTED,
+ DM_STATUS_SERVICE_MANAGEMENT_NOT_SUPPORTED = 6,
// Service error: Device not found.
- DM_STATUS_SERVICE_DEVICE_NOT_FOUND,
+ DM_STATUS_SERVICE_DEVICE_NOT_FOUND = 7,
// Service error: Device token invalid.
- DM_STATUS_SERVICE_MANAGEMENT_TOKEN_INVALID,
+ DM_STATUS_SERVICE_MANAGEMENT_TOKEN_INVALID = 8,
// Service error: Activation pending.
- DM_STATUS_SERVICE_ACTIVATION_PENDING,
+ DM_STATUS_SERVICE_ACTIVATION_PENDING = 9,
// Service error: The serial number is not valid or not known to the server.
- DM_STATUS_SERVICE_INVALID_SERIAL_NUMBER,
+ DM_STATUS_SERVICE_INVALID_SERIAL_NUMBER = 10,
// Service error: The device id used for registration is already taken.
- DM_STATUS_SERVICE_DEVICE_ID_CONFLICT,
+ DM_STATUS_SERVICE_DEVICE_ID_CONFLICT = 11,
// Service error: The licenses have expired or have been exhausted.
- DM_STATUS_SERVICE_MISSING_LICENSES,
+ DM_STATUS_SERVICE_MISSING_LICENSES = 12,
// Service error: The administrator has deprovisioned this client.
- DM_STATUS_SERVICE_DEPROVISIONED,
+ DM_STATUS_SERVICE_DEPROVISIONED = 13,
// Service error: Device registration for the wrong domain.
- DM_STATUS_SERVICE_DOMAIN_MISMATCH,
+ DM_STATUS_SERVICE_DOMAIN_MISMATCH = 14,
// Service error: Policy not found. Error code defined by the DM folks.
DM_STATUS_SERVICE_POLICY_NOT_FOUND = 902,
};
« no previous file with comments | « no previous file | components/policy/core/common/cloud/enterprise_metrics.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698