Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Unified Diff: tools/metrics/histograms/histograms.xml

Side-by-side diff isn't available for this file because of its large size.
Issue 375903002: Fix EnterpriseDeviceManagementStatus UMA enum, add comments. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Cosmetics. Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« no previous file with comments | « components/policy/core/common/policy_loader_win.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index d28b4789dda423a00099da197fc678e389ebb08e..3fa4533dbe098d00fd85cbaf1d6b87b12bc50677 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -36984,6 +36984,10 @@ Therefore, the affected-histogram name has to have at least one dot in it.
</enum>
<enum name="EnterpriseCheckError" type="int">
+ <summary>
+ Defined as DomainCheckErrors in
+ components/policy/core/common/policy_loader_win.cc.
+ </summary>
<int value="0" label="Cound not get net join info."/>
<int value="1" label="Cound not bind to domain controller."/>
</enum>
@@ -36991,7 +36995,8 @@ Therefore, the affected-histogram name has to have at least one dot in it.
<enum name="EnterpriseDeviceManagementStatus" type="int">
<summary>
Status codes produced by DeviceManagementService for requests made to the
- device management server.
+ device management server as defined in
+ components/policy/core/common/cloud/cloud_policy_constants.h.
</summary>
<int value="0" label="SUCCESS"/>
<int value="1" label="REQUEST_INVALID"/>
@@ -37006,13 +37011,15 @@ Therefore, the affected-histogram name has to have at least one dot in it.
<int value="10" label="SERVICE_INVALID_SERIAL_NUMBER"/>
<int value="11" label="SERVICE_DEVICE_ID_CONFLICT"/>
<int value="12" label="SERVICE_MISSING_LICENSES"/>
+ <int value="13" label="SERVICE_DEPROVISIONED"/>
+ <int value="14" label="SERVICE_DOMAIN_MISMATCH"/>
<int value="902" label="SERVICE_POLICY_NOT_FOUND"/>
</enum>
<enum name="EnterpriseDMTokenType" type="int">
<summary>
Result of DMToken operations as defined in
- chrome/browser/policy/enterprise_metrics.h.
+ components/policy/core/common/cloud/enterprise_metrics.h.
</summary>
<int value="0" label="Load Succeeded">
A cached token was successfully loaded from disk.
@@ -37059,7 +37066,7 @@ Therefore, the affected-histogram name has to have at least one dot in it.
<enum name="EnterpriseEnrollmentType" type="int">
<summary>
Result of device enrollment as defined in
- chrome/browser/policy/enterprise_metrics.h.
+ components/policy/core/common/cloud/enterprise_metrics.h.
</summary>
<int value="0" label="Cancelled">
The enrollment screen was closed without completing the enrollment process.
@@ -37488,6 +37495,10 @@ Therefore, the affected-histogram name has to have at least one dot in it.
</enum>
<enum name="EnterprisePolicyInvalidations" type="int">
+ <summary>
+ Defined as PolicyInvalidationType in
+ components/policy/core/common/cloud/enterprise_metrics.h.
+ </summary>
<int value="0" label="No payload; not expired"/>
<int value="1" label="Payload; not expired"/>
<int value="2" label="No payload; expired"/>
@@ -37498,7 +37509,8 @@ Therefore, the affected-histogram name has to have at least one dot in it.
<summary>
Status codes produced by the policy loaders that pull policy settings from
the platform-specific management infrastructure, such as Windows Group
- Policy.
+ Policy. Defined as PolicyLoadStatus in
+ components/policy/core/common/policy_load_status.h.
</summary>
<int value="0" label="STARTED">
Policy load attempt started. This gets logged for each policy load attempt
@@ -37526,6 +37538,10 @@ Therefore, the affected-histogram name has to have at least one dot in it.
</enum>
<enum name="EnterprisePolicyRefresh" type="int">
+ <summary>
+ Defined as MetricPolicyRefresh in
+ components/policy/core/common/cloud/enterprise_metrics.h.
+ </summary>
<int value="0" label="Changed"/>
<int value="1" label="Changed; Invalidations disabled"/>
<int value="2" label="Unchanged"/>
@@ -37535,8 +37551,8 @@ Therefore, the affected-histogram name has to have at least one dot in it.
<enum name="EnterprisePolicyType" type="int">
<summary>
- Result of Policy operations as defined in
- chrome/browser/policy/enterprise_metrics.h.
+ Result of Policy operations as defined as MetricPolicy in
+ components/policy/core/common/cloud/enterprise_metrics.h.
</summary>
<int value="0" label="Load Succeeded">
A cached policy was successfully loaded from disk.
« no previous file with comments | « components/policy/core/common/policy_loader_win.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698