Fix EnterpriseDeviceManagementStatus UMA enum, add comments.

Fix EnterpriseDeviceManagementStatus UMA enum, add comments.

I've gone through the enterprise UMA enums and compared them to their C++
counterparts.  There was a mismatch for EnterpriseDeviceManagementStatus which
is corrected by this CL.  To prevent this kind of error in the future, this CL
adds comments and numeric ids to the C++ enums.

BUG=none

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283571

[Thiemo Nagel, 2014-07-08 15:50:52]

Hi Joao,

could you please take a look?  What do you think?

Thank you!
Thiemo

[Joao da Silva, 2014-07-09 12:21:09]

I didn't spot the mismatch that is fixed by this CL, can you point to it?

The explicit int values add visual clutter that hurt readability, but I agree it
makes it easier to map the the histogram IDs.

lgtm as is.

[Thiemo Nagel, 2014-07-09 12:31:18]

On 2014/07/09 12:21:09, Joao da Silva wrote:
> I didn't spot the mismatch that is fixed by this CL, can you point to it?

The missing values were at <enum name="EnterpriseDeviceManagementStatus"
type="int">:

<int value="13" label="SERVICE_DEPROVISIONED"/>
<int value="14" label="SERVICE_DOMAIN_MISMATCH"/>
 
> The explicit int values add visual clutter that hurt readability, but I agree
it
> makes it easier to map the the histogram IDs.

Also, adding explicit ids helps to drive the point that the ids actually matter,
they aren't arbitrary.

> lgtm as is.

Thank you!

[Thiemo Nagel, 2014-07-09 12:32:54]

Hi Alexei,

could you please take a look at the changes to histograms.xml?

Thank you!
Thiemo

[Alexei Svitkine (slow), 2014-07-14 14:03:04]

lgtm

[Thiemo Nagel, 2014-07-14 14:07:58]

On 2014/07/14 14:03:04, Alexei Svitkine wrote:
> lgtm

Thank you!

[Thiemo Nagel, 2014-07-16 16:49:35]

The CQ bit was checked by tnagel@chromium.org

[commit-bot: I haz the power, 2014-07-16 16:51:09]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/tnagel@chromium.org/375903002/40001

[commit-bot: I haz the power, 2014-07-16 23:19:17]

Change committed as 283571