Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 375883002: Fix compilation error encountered when DEBUG set to 1. (Closed)

Created:
6 years, 5 months ago by simonb (inactive)
Modified:
6 years, 5 months ago
Reviewers:
Anton, anton1, rmcilroy
CC:
chromium-reviews, erikwright+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix compilation error encountered when DEBUG set to 1. Fails to compiler if DEBUG is set to 1. If DEBUG is 0 the error is hidden because LOG_INFO() expands to an empty operation. Fixes: ../../base/android/linker/linker_jni.cc:270:60: error: 'lib_basename' was not declared in this scope BUG=390618 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281815

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M base/android/linker/linker_jni.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
simonb (inactive)
6 years, 5 months ago (2014-07-08 13:28:12 UTC) #1
anton1
On 2014/07/08 13:28:12, simonb wrote: lgtm Thanks.
6 years, 5 months ago (2014-07-08 13:32:22 UTC) #2
simonb (inactive)
The CQ bit was checked by simonb@chromium.org
6 years, 5 months ago (2014-07-08 13:34:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/simonb@chromium.org/375883002/1
6 years, 5 months ago (2014-07-08 13:35:26 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-08 13:35:27 UTC) #5
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 5 months ago (2014-07-08 13:35:28 UTC) #6
rmcilroy
lgtm
6 years, 5 months ago (2014-07-08 13:47:48 UTC) #7
rmcilroy
The CQ bit was checked by rmcilroy@chromium.org
6 years, 5 months ago (2014-07-08 13:47:52 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/simonb@chromium.org/375883002/1
6 years, 5 months ago (2014-07-08 13:48:57 UTC) #9
commit-bot: I haz the power
6 years, 5 months ago (2014-07-08 20:23:56 UTC) #10
Message was sent while issue was closed.
Change committed as 281815

Powered by Google App Engine
This is Rietveld 408576698