Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(501)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 375873006: Rename source_prereqs to inputs in the GN build. (Closed)

Created:
6 years, 5 months ago by brettw
Modified:
6 years, 5 months ago
Reviewers:
jamesr
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, browser-components-watch_chromium.org, yzshen+watch_chromium.org, aandrey+blink_chromium.org, Ilya Sherman, extensions-reviews_chromium.org, vsevik, benquan, ben+mojo_chromium.org, jam, abarth-chromium, darin-cc_chromium.org, devtools-reviews_chromium.org, chromium-apps-reviews_chromium.org, erikwright+watch_chromium.org, dsinclair+watch_chromium.org, piman+watch_chromium.org, rouslan+autofillwatch_chromium.org, tfarina, yurys, Aaron Boodman, paulirish+reviews_chromium.org, Dane Wallinga, dyu1, estade+watch_chromium.org, darin (slow to review), pfeldman
Project:
chromium
Visibility:
Public.

Description

Rename source_prereqs to inputs in the GN build. This variable changed name. R=jamesr@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282076

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -55 lines) Patch
M base/BUILD.gn View 1 3 chunks +9 lines, -9 lines 0 comments Download
M build/compiled_action.gni View 4 chunks +6 lines, -6 lines 0 comments Download
M build/config/android/internal_rules.gni View 3 chunks +3 lines, -3 lines 0 comments Download
M build/config/android/rules.gni View 4 chunks +5 lines, -5 lines 0 comments Download
M build/secondary/chrome/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M build/secondary/third_party/trace-viewer/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M build/secondary/tools/grit/grit_rule.gni View 1 chunk +1 line, -1 line 0 comments Download
M build/secondary/tools/grit/repack.gni View 1 chunk +1 line, -1 line 0 comments Download
M build/util/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/app/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/devtools/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/core/browser/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M components/policy/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/devtools/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/tracing/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M content/gpu/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M device/usb/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M extensions/generated_extensions_api.gni View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/public/tools/bindings/mojom.gni View 1 chunk +1 line, -1 line 0 comments Download
M sandbox/mac/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M third_party/yasm/BUILD.gn View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/yasm/yasm_assemble.gni View 2 chunks +3 lines, -3 lines 0 comments Download
M tools/gn/target_generator.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/gl/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
brettw
6 years, 5 months ago (2014-07-08 21:42:20 UTC) #1
jamesr
lgtm
6 years, 5 months ago (2014-07-09 01:20:34 UTC) #2
brettw
6 years, 5 months ago (2014-07-09 17:29:41 UTC) #3
Message was sent while issue was closed. 
Committed patchset #2 manually as r282076.

Powered by Google App Engine
This is Rietveld 408576698