Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 375873002: DevTools: enable Screencast in DEBUG_DEVTOOLS mode (Closed)

Created:
6 years, 5 months ago by Vladislav Kaznacheev
Modified:
6 years, 5 months ago
Reviewers:
pfeldman
CC:
chromium-reviews, vsevik, jam, yurys, paulirish+reviews_chromium.org, darin-cc_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org, pfeldman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

DevTools: enable Screencast in DEBUG_DEVTOOLS mode This is useful for debugging Screencast without an Android device. BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281755

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M content/browser/devtools/renderer_overrides_handler.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M content/content_browser.gypi View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Vladislav Kaznacheev
6 years, 5 months ago (2014-07-08 12:07:59 UTC) #1
pfeldman
lgtm https://codereview.chromium.org/375873002/diff/1/content/browser/devtools/renderer_overrides_handler.cc File content/browser/devtools/renderer_overrides_handler.cc (right): https://codereview.chromium.org/375873002/diff/1/content/browser/devtools/renderer_overrides_handler.cc#newcode504 content/browser/devtools/renderer_overrides_handler.cc:504: # if defined(OS_LINUX) && defined(DEBUG_DEVTOOLS) #if defined(OS_ANDROID) || ...
6 years, 5 months ago (2014-07-08 12:20:26 UTC) #2
Vladislav Kaznacheev
The CQ bit was checked by kaznacheev@chromium.org
6 years, 5 months ago (2014-07-08 12:23:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kaznacheev@chromium.org/375873002/20001
6 years, 5 months ago (2014-07-08 12:23:59 UTC) #4
Vladislav Kaznacheev
https://codereview.chromium.org/375873002/diff/1/content/browser/devtools/renderer_overrides_handler.cc File content/browser/devtools/renderer_overrides_handler.cc (right): https://codereview.chromium.org/375873002/diff/1/content/browser/devtools/renderer_overrides_handler.cc#newcode504 content/browser/devtools/renderer_overrides_handler.cc:504: # if defined(OS_LINUX) && defined(DEBUG_DEVTOOLS) On 2014/07/08 12:20:26, pfeldman ...
6 years, 5 months ago (2014-07-08 12:25:07 UTC) #5
commit-bot: I haz the power
Change committed as 281755
6 years, 5 months ago (2014-07-08 15:12:38 UTC) #6
vsevik
6 years, 5 months ago (2014-07-09 07:47:39 UTC) #7
Message was sent while issue was closed. 
A revert of this CL has been created in
https://codereview.chromium.org/379123002/ by vsevik@chromium.org.

The reason for reverting is: Breaks docked DevTools.

Powered by Google App Engine
This is Rietveld 408576698