Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 375793003: [fsp] Rename file_system_name to display_name for consistency. (Closed)

Created:
6 years, 5 months ago by mtomasz
Modified:
6 years, 5 months ago
Reviewers:
Nikita (slow), hirono
CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

[fsp] Rename file_system_name to display_name for consistency. On the JS side, the argument is called displayName, so on C++ side it should be display_name for consistency. TBR=nkostylev@chromium.org TEST=Not related. Refactoring only. BUG=248427 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281717

Patch Set 1 #

Patch Set 2 : Fixed. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -54 lines) Patch
M chrome/browser/chromeos/file_manager/volume_manager.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/file_system_provider/mount_path_util_unittest.cc View 1 7 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/notification_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/file_system_provider/operations/close_file_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/file_system_provider/operations/get_metadata_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/file_system_provider/operations/open_file_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/file_system_provider/operations/read_directory_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/file_system_provider/operations/read_file_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/file_system_provider/operations/unmount_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/file_system_provider/provided_file_system_info.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/provided_file_system_info.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/provided_file_system_unittest.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/service.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/service.cc View 1 5 chunks +10 lines, -10 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/service_unittest.cc View 1 14 chunks +18 lines, -19 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/provided_file_systems_ui.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (0 generated)
mtomasz
@hirono: PTAL. Thanks.
6 years, 5 months ago (2014-07-08 05:22:45 UTC) #1
hirono
lgtm!
6 years, 5 months ago (2014-07-08 05:31:34 UTC) #2
mtomasz
Thanks!
6 years, 5 months ago (2014-07-08 05:31:52 UTC) #3
mtomasz
The CQ bit was checked by mtomasz@chromium.org
6 years, 5 months ago (2014-07-08 05:31:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/375793003/1
6 years, 5 months ago (2014-07-08 05:33:20 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 5 months ago (2014-07-08 07:11:32 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-08 07:23:08 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_clang_dbg on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chromeos_clang_dbg/builds/28223) linux_chromium_chromeos_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chromeos_rel/builds/45285)
6 years, 5 months ago (2014-07-08 07:23:09 UTC) #8
mtomasz
The CQ bit was checked by mtomasz@chromium.org
6 years, 5 months ago (2014-07-08 08:56:55 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/375793003/20001
6 years, 5 months ago (2014-07-08 08:58:12 UTC) #10
mtomasz
@nkostylev: PTAL at provided_file_systems_ui.cc. Thanks.
6 years, 5 months ago (2014-07-08 09:50:29 UTC) #11
commit-bot: I haz the power
6 years, 5 months ago (2014-07-08 11:05:28 UTC) #12
Message was sent while issue was closed.
Change committed as 281717

Powered by Google App Engine
This is Rietveld 408576698