Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(542)

Side by Side Diff: content/renderer/render_frame_impl.h

Issue 375713002: Ties RenderFrameImpl VIDEO_HOLE observer to lifetime of RenderWidget. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: only hook up observer for known media playback Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | content/renderer/render_frame_impl.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_RENDERER_RENDER_FRAME_IMPL_H_ 5 #ifndef CONTENT_RENDERER_RENDER_FRAME_IMPL_H_
6 #define CONTENT_RENDERER_RENDER_FRAME_IMPL_H_ 6 #define CONTENT_RENDERER_RENDER_FRAME_IMPL_H_
7 7
8 #include <vector> 8 #include <vector>
9 9
10 #include "base/basictypes.h" 10 #include "base/basictypes.h"
(...skipping 620 matching lines...) Expand 10 before | Expand all | Expand 10 after
631 RendererMediaPlayerManager* media_player_manager_; 631 RendererMediaPlayerManager* media_player_manager_;
632 #endif 632 #endif
633 633
634 #if defined(ENABLE_BROWSER_CDMS) 634 #if defined(ENABLE_BROWSER_CDMS)
635 // Manage all CDMs in this render frame for communicating with the real CDM in 635 // Manage all CDMs in this render frame for communicating with the real CDM in
636 // the browser process. It's okay to use a raw pointer since it's a 636 // the browser process. It's okay to use a raw pointer since it's a
637 // RenderFrameObserver. 637 // RenderFrameObserver.
638 RendererCdmManager* cdm_manager_; 638 RendererCdmManager* cdm_manager_;
639 #endif 639 #endif
640 640
641 #if defined(VIDEO_HOLE)
642 // Whether or not this RenderFrameImpl contains a media player. Used to
643 // register as an observer for video-hole-specific events.
644 bool contains_media_player_;
645 #endif
646
641 // The geolocation dispatcher attached to this frame, lazily initialized. 647 // The geolocation dispatcher attached to this frame, lazily initialized.
642 GeolocationDispatcher* geolocation_dispatcher_; 648 GeolocationDispatcher* geolocation_dispatcher_;
643 649
644 // The push messaging dispatcher attached to this frame, lazily initialized. 650 // The push messaging dispatcher attached to this frame, lazily initialized.
645 PushMessagingDispatcher* push_messaging_dispatcher_; 651 PushMessagingDispatcher* push_messaging_dispatcher_;
646 652
647 ServiceRegistryImpl service_registry_; 653 ServiceRegistryImpl service_registry_;
648 654
649 // The screen orientation dispatcher attached to the frame, lazily 655 // The screen orientation dispatcher attached to the frame, lazily
650 // initialized. 656 // initialized.
651 ScreenOrientationDispatcher* screen_orientation_dispatcher_; 657 ScreenOrientationDispatcher* screen_orientation_dispatcher_;
652 658
653 base::WeakPtrFactory<RenderFrameImpl> weak_factory_; 659 base::WeakPtrFactory<RenderFrameImpl> weak_factory_;
654 660
655 DISALLOW_COPY_AND_ASSIGN(RenderFrameImpl); 661 DISALLOW_COPY_AND_ASSIGN(RenderFrameImpl);
656 }; 662 };
657 663
658 } // namespace content 664 } // namespace content
659 665
660 #endif // CONTENT_RENDERER_RENDER_FRAME_IMPL_H_ 666 #endif // CONTENT_RENDERER_RENDER_FRAME_IMPL_H_
OLDNEW
« no previous file with comments | « no previous file | content/renderer/render_frame_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698