Fix buffer overrun in Bluetooth LE code.

Fix buffer overrun in Bluetooth LE code.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281967

[rpaquay, 2014-07-08 23:12:03]

I am adding unit test in a follow up CL, but it requires moving code around and
I wanted to keep this CL simple.

[xiyuan, 2014-07-08 23:26:34]

https://codereview.chromium.org/375703009/diff/20001/device/bluetooth/bluetoo...
File device/bluetooth/bluetooth_low_energy_win.cc (right):

https://codereview.chromium.org/375703009/diff/20001/device/bluetooth/bluetoo...
device/bluetooth/bluetooth_low_energy_win.cc:235:
instance_id.get()[actual_length - 1] = 0;
Would this have similar problem since |instance_id| is WCHAR* and
|actual_length| is in bytes?

[rpaquay, 2014-07-08 23:51:13]

https://codereview.chromium.org/375703009/diff/20001/device/bluetooth/bluetoo...
File device/bluetooth/bluetooth_low_energy_win.cc (right):

https://codereview.chromium.org/375703009/diff/20001/device/bluetooth/bluetoo...
device/bluetooth/bluetooth_low_energy_win.cc:235:
instance_id.get()[actual_length - 1] = 0;
On 2014/07/08 23:26:33, xiyuan wrote:
> Would this have similar problem since |instance_id| is WCHAR* and
> |actual_length| is in bytes?

I don't believe so. The msdn doc mentions that the last 2 parameters are
expressed in "number of characters":
http://msdn.microsoft.com/en-us/library/windows/hardware/ff551106(v=vs.85).aspx

[xiyuan, 2014-07-09 00:24:03]

lgtm

[rpaquay, 2014-07-09 01:34:30]

The CQ bit was checked by rpaquay@chromium.org

[commit-bot: I haz the power, 2014-07-09 01:35:35]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/rpaquay@chromium.org/375703009/20001

[commit-bot: I haz the power, 2014-07-09 05:59:54]

Change committed as 281967