Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 375703002: Turn on threaded DMQuiltTask drawing for old-format SkPictures too. (Closed)

Created:
6 years, 5 months ago by mtklein_C
Modified:
6 years, 5 months ago
Reviewers:
reed, mtklein, robertphillips, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Turn on threaded DMQuiltTask drawing for old-format SkPictures too. This required the same SkBitmap copying that we added today to SkRecord. BUG=skia: Committed: https://skia.googlesource.com/skia/+/eeb1f15891ee9f96f2c5d6e1c3d5a656208f3760

Patch Set 1 #

Patch Set 2 : borrow #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -6 lines) Patch
M dm/DMQuiltTask.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkPicturePlayback.cpp View 1 4 chunks +10 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
mtklein
6 years, 5 months ago (2014-07-07 22:40:16 UTC) #1
reed1
I think I really liked the helper function you tried earlier. I think that is ...
6 years, 5 months ago (2014-07-07 22:43:42 UTC) #2
mtklein
On 2014/07/07 22:43:42, reed1 wrote: > I think I really liked the helper function you ...
6 years, 5 months ago (2014-07-07 22:47:44 UTC) #3
reed1
lgtm
6 years, 5 months ago (2014-07-07 22:48:57 UTC) #4
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 5 months ago (2014-07-07 22:53:06 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/375703002/20001
6 years, 5 months ago (2014-07-07 22:53:39 UTC) #6
commit-bot: I haz the power
6 years, 5 months ago (2014-07-07 23:17:41 UTC) #7
Message was sent while issue was closed.
Change committed as eeb1f15891ee9f96f2c5d6e1c3d5a656208f3760

Powered by Google App Engine
This is Rietveld 408576698