Snap layers in views to physical pixel

ui/views/view_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <map>
 
 #include "base/memory/scoped_ptr.h"
 #include "base/rand_util.h"
 #include "base/strings/string_util.h"
+#include "base/strings/stringprintf.h"
 #include "base/strings/utf_string_conversions.h"
 #include "grit/ui_strings.h"
 #include "ui/base/accelerators/accelerator.h"
 #include "ui/base/clipboard/clipboard.h"
 #include "ui/base/l10n/l10n_util.h"
 #include "ui/compositor/compositor.h"
 #include "ui/compositor/layer.h"
 #include "ui/compositor/layer_animator.h"
 #include "ui/compositor/test/draw_waiter_for_test.h"
 #include "ui/events/event.h"
@@ skipping 3877 matching lines @@
   EXPECT_EQ(1U, test_view->last_cull_set_.count(v1));
 
   // We should find v2 and v3 in the widget_view cull_set.
   EXPECT_EQ(4U, widget_view->last_cull_set_.size());
   EXPECT_EQ(1U, widget_view->last_cull_set_.count(test_widget->GetRootView()));
   EXPECT_EQ(1U, widget_view->last_cull_set_.count(widget_view));
   EXPECT_EQ(1U, widget_view->last_cull_set_.count(v2));
   EXPECT_EQ(1U, widget_view->last_cull_set_.count(v3));
 }
 
+namespace {
+
+std::string ToString(const gfx::Vector2dF& vector) {
+  return base::StringPrintf("%.2f %0.2f", vector.x(), vector.y());
+}
+
+}  // namespace
+
+TEST_F(ViewLayerTest, SnapLayerToPixel) {
+  View* v1 = new View;
+
+  View* v11 = new View;
+  v1->AddChildView(v11);
+
+  widget()->SetContentsView(v1);
+
+  const gfx::Size& size = GetRootLayer()->GetCompositor()->size();
+  GetRootLayer()->GetCompositor()->SetScaleAndSize(1.25f, size);
+
+  v11->SetBoundsRect(gfx::Rect(1, 1, 10, 10));
+  v1->SetBoundsRect(gfx::Rect(1, 1, 10, 10));
+  v11->SetPaintToLayer(true);
+
+  EXPECT_EQ("0.40 0.40", ToString(v11->layer()->subpixel_position_offset()));
+
+  // Creating a layer in parent should update the child view's layer offset.
+  v1->SetPaintToLayer(true);
+  EXPECT_EQ("-0.20 -0.20", ToString(v1->layer()->subpixel_position_offset()));
+  EXPECT_EQ("-0.20 -0.20", ToString(v11->layer()->subpixel_position_offset()));
+
+  // DSF change shoud get propagated and update offsets.

[danakj, 2014/07/15 21:11:02]

should

[oshima, 2014/07/15 22:28:42]

Done.

+  GetRootLayer()->GetCompositor()->SetScaleAndSize(1.5f, size);
+  EXPECT_EQ("0.33 0.33", ToString(v1->layer()->subpixel_position_offset()));
+  EXPECT_EQ("0.33 0.33", ToString(v11->layer()->subpixel_position_offset()));
+
+  // Deleting parent' layer should update the child view's layer's offset.

[danakj, 2014/07/15 21:11:02]

s/'//

[oshima, 2014/07/15 22:28:42]

Done.

+  v1->SetPaintToLayer(false);
+  EXPECT_EQ("0.00 0.00", ToString(v11->layer()->subpixel_position_offset()));
+
+  // Setting parent view should update the child view's layer's offset.
+  v1->SetBoundsRect(gfx::Rect(2, 2, 10, 10));
+  EXPECT_EQ("0.33 0.33", ToString(v11->layer()->subpixel_position_offset()));
+
+  // Setting integral DSF should reset the offset.
+  GetRootLayer()->GetCompositor()->SetScaleAndSize(2.0f, size);
+  EXPECT_EQ("0.00 0.00", ToString(v11->layer()->subpixel_position_offset()));
+}
+
 TEST_F(ViewTest, FocusableAssertions) {
   // View subclasses may change insets based on whether they are focusable,
   // which effects the preferred size. To avoid preferred size changing around
   // these Views need to key off the last value set to SetFocusable(), not
   // whether the View is focusable right now. For this reason it's important
   // that focusable() return the last value passed to SetFocusable and not
   // whether the View is focusable right now.
   TestView view;
   view.SetFocusable(true);
   EXPECT_TRUE(view.focusable());
@@ skipping 47 matching lines @@
   // notification.
   TestView* test_view_child_2 = new TestView();
   test_view->AddChildView(test_view_child_2);
   EXPECT_TRUE(test_view_child_2->native_theme_);
   EXPECT_EQ(widget->GetNativeTheme(), test_view_child_2->native_theme_);
 
   widget->CloseNow();
 }
 
 }  // namespace views