Snap layers in views to physical pixel

ui/compositor/layer_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/basictypes.h"
 #include "base/bind.h"
 #include "base/compiler_specific.h"
 #include "base/debug/trace_event.h"
 #include "base/file_util.h"
 #include "base/files/file_path.h"
 #include "base/json/json_reader.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/message_loop/message_loop.h"
 #include "base/path_service.h"
 #include "base/strings/string_util.h"
 #include "base/strings/stringprintf.h"
 #include "cc/layers/delegated_frame_provider.h"
 #include "cc/layers/delegated_frame_resource_collection.h"
 #include "cc/layers/layer.h"
 #include "cc/output/copy_output_request.h"
 #include "cc/output/copy_output_result.h"
 #include "cc/output/delegated_frame_data.h"
 #include "cc/test/pixel_test_utils.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "ui/compositor/compositor_observer.h"
+#include "ui/compositor/dip_util.h"
 #include "ui/compositor/layer.h"
 #include "ui/compositor/layer_animation_sequence.h"
 #include "ui/compositor/layer_animator.h"
 #include "ui/compositor/test/context_factories_for_test.h"
 #include "ui/compositor/test/draw_waiter_for_test.h"
 #include "ui/compositor/test/test_compositor_host.h"
 #include "ui/compositor/test/test_layers.h"
 #include "ui/gfx/canvas.h"
 #include "ui/gfx/codec/png_codec.h"
 #include "ui/gfx/gfx_paths.h"
@@ skipping 1511 matching lines @@
   compositor()->SetRootLayer(root.get());
 
   child->SetAnimator(LayerAnimator::CreateImplicitAnimator());
   child->SetOpacity(0.5f);
   EXPECT_TRUE(compositor()->layer_animator_collection()->HasActiveAnimators());
 
   child.reset();
   EXPECT_FALSE(compositor()->layer_animator_collection()->HasActiveAnimators());
 }
 
+namespace {
+
+std::string ToString(const gfx::Vector2dF& vector) {

[danakj, 2014/07/15 21:11:02]

Vector2dFToHundredthPrecisionString or something?

[oshima, 2014/07/15 22:28:42]

Done.

+  return base::StringPrintf("%.2f %0.2f", vector.x(), vector.y());
+}
+
+}  // namespace
+
+TEST_F(LayerWithRealCompositorTest, SnapLayerToPixels) {
+  scoped_ptr<Layer> root(CreateLayer(LAYER_TEXTURED));
+  scoped_ptr<Layer> c1(CreateLayer(LAYER_TEXTURED));
+  scoped_ptr<Layer> c11(CreateLayer(LAYER_TEXTURED));
+
+  GetCompositor()->SetScaleAndSize(1.25f, gfx::Size(100, 100));
+  GetCompositor()->SetRootLayer(root.get());
+  root->Add(c1.get());
+  c1->Add(c11.get());
+
+  root->SetBounds(gfx::Rect(0, 0, 100, 100));
+  c1->SetBounds(gfx::Rect(1, 1, 10, 10));
+  c11->SetBounds(gfx::Rect(1, 1, 10, 10));
+  SnapLayerToPhysicalPixelBoundary(root.get(), c11.get());
+  // 0.5 at 1.25 scale : (0.25 + 0.25) / 1.25 = 0.4
+  EXPECT_EQ("0.40 0.40", ToString(c11->subpixel_position_offset()));
+
+  GetCompositor()->SetScaleAndSize(1.5f, gfx::Size(100, 100));
+  SnapLayerToPhysicalPixelBoundary(root.get(), c11.get());
+  // c11 msut already be alignedt at 1.5 scale.

[danakj, 2014/07/15 21:11:02]

"must" "aligned"

[oshima, 2014/07/15 22:28:42]

Done.

+  EXPECT_EQ("0.00 0.00", ToString(c11->subpixel_position_offset()));
+
+  c11->SetBounds(gfx::Rect(2, 2, 10, 10));
+  SnapLayerToPhysicalPixelBoundary(root.get(), c11.get());
+  // c11 is now off the pixel.
+  // 0.5 / 1.5 = 0.333...
+  EXPECT_EQ("0.33 0.33", ToString(c11->subpixel_position_offset()));
+}
+
 }  // namespace ui