runtime/vm/intermediate_language_arm.cc - Issue 375693004: Don't assign safepoint at the definition to the definition's live-range.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/intermediate_language_arm.cc

Issue 375693004: Don't assign safepoint at the definition to the definition's live-range. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/intermediate_language_arm.cc

diff --git a/runtime/vm/intermediate_language_arm.cc b/runtime/vm/intermediate_language_arm.cc

index 2e314d00bc897cca7d1385aba13528f7477bf53a..64e9394258e2281a8bdb0ed48fcbcc70ef21167c 100644

--- a/runtime/vm/intermediate_language_arm.cc

+++ b/runtime/vm/intermediate_language_arm.cc

@@ -1926,7 +1926,7 @@ class StoreInstanceFieldSlowPath : public SlowPathCode {

const ExternalLabel label(stub.EntryPoint());

LocationSummary* locs = instruction_->locs();

- locs->live_registers()->Remove(locs->out(0));

+ locs->live_registers()->Remove(locs->temp(0));

compiler->SaveLiveRegisters(locs);

compiler->GenerateCall(Scanner::kNoSourcePos, // No token position.

@@ -2400,7 +2400,7 @@ class BoxDoubleSlowPath : public SlowPathCode {

const ExternalLabel label(stub.EntryPoint());

LocationSummary* locs = instruction_->locs();

- locs->live_registers()->Remove(locs->out(0));

+ ASSERT(!locs->live_registers()->Contains(locs->out(0)));

compiler->SaveLiveRegisters(locs);

compiler->GenerateCall(Scanner::kNoSourcePos, // No token position.

@@ -2432,7 +2432,7 @@ class BoxFloat32x4SlowPath : public SlowPathCode {

const ExternalLabel label(stub.EntryPoint());

LocationSummary* locs = instruction_->locs();

- locs->live_registers()->Remove(locs->out(0));

+ ASSERT(!locs->live_registers()->Contains(locs->out(0)));

compiler->SaveLiveRegisters(locs);

compiler->GenerateCall(Scanner::kNoSourcePos, // No token position.

@@ -2464,7 +2464,7 @@ class BoxFloat64x2SlowPath : public SlowPathCode {

const ExternalLabel label(stub.EntryPoint());

LocationSummary* locs = instruction_->locs();

- locs->live_registers()->Remove(locs->out(0));

+ ASSERT(!locs->live_registers()->Contains(locs->out(0)));

compiler->SaveLiveRegisters(locs);

compiler->GenerateCall(Scanner::kNoSourcePos, // No token position.

@@ -3700,7 +3700,7 @@ class BoxInt32x4SlowPath : public SlowPathCode {

const ExternalLabel label(stub.EntryPoint());

LocationSummary* locs = instruction_->locs();

- locs->live_registers()->Remove(locs->out(0));

+ ASSERT(!locs->live_registers()->Contains(locs->out(0)));

compiler->SaveLiveRegisters(locs);

compiler->GenerateCall(Scanner::kNoSourcePos, // No token position.

@@ -5920,7 +5920,7 @@ class BoxIntegerSlowPath : public SlowPathCode {

const ExternalLabel label(stub.EntryPoint());

LocationSummary* locs = instruction_->locs();

- locs->live_registers()->Remove(locs->out(0));

+ ASSERT(!locs->live_registers()->Contains(locs->out(0)));

compiler->SaveLiveRegisters(locs);

compiler->GenerateCall(Scanner::kNoSourcePos, // No token position.

« no previous file with comments | « runtime/vm/flow_graph_allocator.cc ('k') | runtime/vm/intermediate_language_arm64.cc » ('j') | no next file with comments »