Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 375683002: Annotate leak in ChromeBookmarkClient. (Closed)

Created:
6 years, 5 months ago by Sigurður Ásgeirsson
Modified:
6 years, 5 months ago
Reviewers:
gab, brettw
CC:
cpu_(ooo_6.6-7.5), chromium-reviews, tfarina, browser-components-watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M chrome/browser/bookmarks/chrome_bookmark_client.cc View 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Sigurður Ásgeirsson
Please take a look.
6 years, 5 months ago (2014-07-07 20:59:17 UTC) #1
gab
lgtm
6 years, 5 months ago (2014-07-07 21:00:32 UTC) #2
Sigurður Ásgeirsson
The CQ bit was checked by siggi@chromium.org
6 years, 5 months ago (2014-07-07 21:00:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/siggi@chromium.org/375683002/1
6 years, 5 months ago (2014-07-07 21:01:15 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium ...
6 years, 5 months ago (2014-07-08 00:43:57 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-08 01:24:46 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_aosp on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/90403)
6 years, 5 months ago (2014-07-08 01:24:47 UTC) #7
Sigurður Ásgeirsson
The CQ bit was checked by siggi@chromium.org
6 years, 5 months ago (2014-07-08 02:02:21 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/siggi@chromium.org/375683002/1
6 years, 5 months ago (2014-07-08 02:03:56 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium ...
6 years, 5 months ago (2014-07-08 04:31:20 UTC) #10
commit-bot: I haz the power
6 years, 5 months ago (2014-07-08 05:15:22 UTC) #11
Message was sent while issue was closed.
Change committed as 281670

Powered by Google App Engine
This is Rietveld 408576698