Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(414)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 375673002: Remove unneeded getters/setters (Closed)

Created:
6 years, 5 months ago by rwlbuis
Modified:
6 years, 5 months ago
Reviewers:
adamk
CC:
arv+blink, blink-reviews, blink-reviews-html_chromium.org, Inactive, dglazkov+blink, krit, ed+blinkwatch_opera.com, f(malita), fs, gyuyoung.kim_webkit.org, kouhei+svg_chromium.org, pdr., Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Remove unneeded getters/setters Remove unneeded getters/setters, these methods are unneeded or not used. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177700

Patch Set 1 #

Patch Set 2 : Another attempt #

Patch Set 3 : Add more #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -22 lines) Patch
M Source/core/html/HTMLAnchorElement.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/HTMLAnchorElement.cpp View 2 chunks +1 line, -6 lines 0 comments Download
M Source/core/html/HTMLEmbedElement.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/HTMLEmbedElement.cpp View 1 2 1 chunk +0 lines, -5 lines 1 comment Download
M Source/core/html/HTMLImageElement.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/html/HTMLImageElement.cpp View 1 1 chunk +0 lines, -5 lines 0 comments Download
M Source/core/html/HTMLStyleElement.h View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
rwlbuis
PTAL
6 years, 5 months ago (2014-07-08 20:53:47 UTC) #1
adamk
lgtm if I'm correct about the imageSourceURL bit https://codereview.chromium.org/375673002/diff/40001/Source/core/html/HTMLEmbedElement.cpp File Source/core/html/HTMLEmbedElement.cpp (left): https://codereview.chromium.org/375673002/diff/40001/Source/core/html/HTMLEmbedElement.cpp#oldcode191 Source/core/html/HTMLEmbedElement.cpp:191: return ...
6 years, 5 months ago (2014-07-08 22:11:18 UTC) #2
rwlbuis
On 2014/07/08 22:11:18, adamk wrote: > lgtm if I'm correct about the imageSourceURL bit Thanks! ...
6 years, 5 months ago (2014-07-08 22:17:20 UTC) #3
rwlbuis
The CQ bit was checked by rob.buis@samsung.com
6 years, 5 months ago (2014-07-08 22:17:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/375673002/40001
6 years, 5 months ago (2014-07-08 22:17:55 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_compile_dbg on tryserver.blink ...
6 years, 5 months ago (2014-07-08 23:21:46 UTC) #6
commit-bot: I haz the power
6 years, 5 months ago (2014-07-08 23:45:31 UTC) #7
Message was sent while issue was closed. 
Change committed as 177700

Powered by Google App Engine
This is Rietveld 408576698