Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 375623002: Add a tracing line to ApplyWebPreferences. This is a potentially very expensive operation. (Closed)

Created:
6 years, 5 months ago by chrishtr
Modified:
6 years, 5 months ago
Reviewers:
jamesr
CC:
chromium-reviews, darin-cc_chromium.org, jam
Project:
chromium
Visibility:
Public.

Description

Add a tracing line to UpdateWebPreferences. This is a potentially very expensive operation. BUG=390799 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281785

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M content/renderer/web_preferences.cc View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
chrishtr
6 years, 5 months ago (2014-07-07 17:29:19 UTC) #1
jamesr
lgtm (although once we fix this then it won't be expensive any more)
6 years, 5 months ago (2014-07-07 19:29:28 UTC) #2
chrishtr
The CQ bit was checked by chrishtr@chromium.org
6 years, 5 months ago (2014-07-07 19:31:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/chrishtr@chromium.org/375623002/1
6 years, 5 months ago (2014-07-07 19:32:42 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium ...
6 years, 5 months ago (2014-07-07 22:18:15 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-07 22:42:52 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_aosp on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/90277)
6 years, 5 months ago (2014-07-07 22:42:52 UTC) #7
chrishtr
The CQ bit was checked by chrishtr@chromium.org
6 years, 5 months ago (2014-07-08 17:38:19 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/chrishtr@chromium.org/375623002/1
6 years, 5 months ago (2014-07-08 17:41:10 UTC) #9
commit-bot: I haz the power
6 years, 5 months ago (2014-07-08 19:11:18 UTC) #10
Message was sent while issue was closed.
Change committed as 281785

Powered by Google App Engine
This is Rietveld 408576698