Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Issue 375593004: [Search] Adding a URLDataSource for search feature (Closed)

Created:
6 years, 5 months ago by Mathieu
Modified:
6 years, 5 months ago
Reviewers:
Jered
CC:
chromium-reviews, skanuj+watch_chromium.org, melevin+watch_chromium.org, dhollowa+watch_chromium.org, dougw+watch_chromium.org, donnd+watch_chromium.org, dominich, jfweitz+watch_chromium.org, David Black, samarth+watch_chromium.org, kmadhusu+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

[Search] Adding a URLDataSource for search feature This implements the first-run flow for the contextual search feature. Resources are being committed in a different CL. BUG=374932 TEST=going to chrome://contextual-search/ Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281818

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+117 lines, -0 lines) Patch
A chrome/browser/search/contextual_search_promo_source.h View 1 chunk +39 lines, -0 lines 0 comments Download
A chrome/browser/search/contextual_search_promo_source.cc View 1 chunk +76 lines, -0 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Mathieu
Hi Jered, Can you have a look? Thanks
6 years, 5 months ago (2014-07-07 19:48:18 UTC) #1
Jered
On 2014/07/07 19:48:18, Mathieu Perreault wrote: > Hi Jered, > > Can you have a ...
6 years, 5 months ago (2014-07-07 20:19:39 UTC) #2
Jered
On 2014/07/07 20:19:39, Jered wrote: > On 2014/07/07 19:48:18, Mathieu Perreault wrote: > > Hi ...
6 years, 5 months ago (2014-07-07 20:20:32 UTC) #3
Mathieu
The CQ bit was checked by mathp@chromium.org
6 years, 5 months ago (2014-07-08 13:51:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mathp@chromium.org/375593004/1
6 years, 5 months ago (2014-07-08 13:52:35 UTC) #5
commit-bot: I haz the power
6 years, 5 months ago (2014-07-08 20:25:22 UTC) #6
Message was sent while issue was closed.
Change committed as 281818

Powered by Google App Engine
This is Rietveld 408576698