Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(344)

Issue 375593002: Do not set the mouse event handler if Widget::SetCapture() fails (Closed)

Created:
6 years, 5 months ago by pkotwicz
Modified:
6 years, 5 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina, ben+views_chromium.org, tdanderson+views_chromium.org, dcheng
Project:
chromium
Visibility:
Public.

Description

Do not set the mouse event handler if Widget::SetCapture() fails. In particular, Widget::SetCapture() fails if the widget is not visible. BUG=None TEST=WidgetCaptureTest.FailedCaptureRequestIsNoop Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283633

Patch Set 1 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -10 lines) Patch
M chrome/browser/ui/views/tabs/tab_drag_controller.cc View 1 chunk +0 lines, -6 lines 1 comment Download
M ui/views/widget/desktop_aura/desktop_window_tree_host_win.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ui/views/widget/widget.cc View 1 chunk +8 lines, -2 lines 0 comments Download
M ui/views/widget/widget_interactive_uitest.cc View 1 chunk +33 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
pkotwicz
Scott, can you please take a look? This is a bug I ran into while ...
6 years, 5 months ago (2014-07-16 18:50:11 UTC) #1
sky
I'm curious, when does setting capture failure? AFAICT DesktopWindowTreeHostX11::SetCapture always succeeds.
6 years, 5 months ago (2014-07-16 19:39:46 UTC) #2
pkotwicz
Widget::SetCapture() fails if the widget is not visible
6 years, 5 months ago (2014-07-16 19:41:37 UTC) #3
sky
Ah, makes sense. LGTM
6 years, 5 months ago (2014-07-16 19:41:59 UTC) #4
pkotwicz
The CQ bit was checked by pkotwicz@chromium.org
6 years, 5 months ago (2014-07-16 19:42:31 UTC) #5
pkotwicz
For the sake of completeness, the logic which makes setting capture fail if the window ...
6 years, 5 months ago (2014-07-16 19:44:16 UTC) #6
pkotwicz
The CQ bit was unchecked by pkotwicz@chromium.org
6 years, 5 months ago (2014-07-16 19:45:30 UTC) #7
pkotwicz
The CQ bit was checked by pkotwicz@chromium.org
6 years, 5 months ago (2014-07-16 19:46:39 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/375593002/120001
6 years, 5 months ago (2014-07-16 19:48:58 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel on tryserver.chromium ...
6 years, 5 months ago (2014-07-16 23:03:24 UTC) #10
commit-bot: I haz the power
6 years, 5 months ago (2014-07-17 04:04:35 UTC) #11
Message was sent while issue was closed.
Change committed as 283633

Powered by Google App Engine
This is Rietveld 408576698