Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(957)

Issue 375553002: Revert of Allow git cl also in repos with read-only git-svn. (Closed)

Created:
6 years, 5 months ago by Daniel Bratell
Modified:
6 years, 5 months ago
Reviewers:
iannucci, Torne
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Project:
tools
Visibility:
Public.

Description

Revert of Allow git cl also in repos with read-only git-svn. (https://codereview.chromium.org/344013005/) Reason for revert: Breaks WebRTC (and possibly other projects actually using https:// for svn access). Original issue's description: > Allow git cl also in repos with read-only git-svn. > > If you have read-only git-svn git cl would still try > to use svn commands, which would then fail. This > changes git cl to only use git-svn if the remote > svn repository use the svn:// protocol. It matches > how chromium works and it allowed me to upload a patch. > > BUG=391430 > > R=iannucci > > Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=281500 TBR=iannucci@chromium.org NOTREECHECKS=true NOTRY=true BUG=391430 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=281513

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -12 lines) Patch
M git_cl.py View 1 chunk +3 lines, -7 lines 0 comments Download
M tests/git_cl_test.py View 3 chunks +4 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Daniel Bratell
Created Revert of Allow git cl also in repos with read-only git-svn.
6 years, 5 months ago (2014-07-07 09:18:19 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bratell@opera.com/375553002/1
6 years, 5 months ago (2014-07-07 09:19:13 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-07 09:19:13 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 5 months ago (2014-07-07 09:19:14 UTC) #4
Torne
lgtm
6 years, 5 months ago (2014-07-07 09:25:10 UTC) #5
Daniel Bratell
The CQ bit was checked by bratell@opera.com
6 years, 5 months ago (2014-07-07 09:27:06 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bratell@opera.com/375553002/1
6 years, 5 months ago (2014-07-07 09:28:14 UTC) #7
commit-bot: I haz the power
6 years, 5 months ago (2014-07-07 09:30:26 UTC) #8
Message was sent while issue was closed.
Change committed as 281513

Powered by Google App Engine
This is Rietveld 408576698