[fsp] Add support for deleting entries.

[fsp] Add support for deleting entries.

This CL adds support for deleting files and directories, including recursively.
The new event in IDL has [nodoc], since we don't want to show it on
developer.chrome.com before most of the R/W features are done.

TBR=kalman@chromium.org
TEST=unit_tests, browser_tests: *FileSystemProvider*DeleteEntry*
BUG=391362
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282605

[mtomasz, 2014-07-07 07:55:00]

This is almost an identical CL to: 366263002, with exception to
provider_async_file_util.cc/h and JS tests.

@kinaba: PTAL at C++.
@hirono: PTAL at JS.
@benwells: PTAL at IDL.

Thanks.

[kinaba, 2014-07-07 08:06:19]

c++ lgtm

[hirono, 2014-07-07 08:30:44]

https://codereview.chromium.org/375543002/diff/1/chrome/test/data/extensions/...
File
chrome/test/data/extensions/api_test/file_system_provider/delete_entry/test.js
(right):

https://codereview.chromium.org/375543002/diff/1/chrome/test/data/extensions/...
chrome/test/data/extensions/api_test/file_system_provider/delete_entry/test.js:90:
function onGetMetadataRequested(options, onSuccess, onError) {
Could you use test_util.onGetMetadataRequestedDefault?

https://codereview.chromium.org/375543002/diff/1/chrome/test/data/extensions/...
chrome/test/data/extensions/api_test/file_system_provider/delete_entry/test.js:139:
TESTING_B_DIRECTORY.name) {
The recursive flag is needed for deleting TESTING_B_DIRECTORY?

[mtomasz, 2014-07-07 08:33:11]

https://codereview.chromium.org/375543002/diff/1/chrome/test/data/extensions/...
File
chrome/test/data/extensions/api_test/file_system_provider/delete_entry/test.js
(right):

https://codereview.chromium.org/375543002/diff/1/chrome/test/data/extensions/...
chrome/test/data/extensions/api_test/file_system_provider/delete_entry/test.js:90:
function onGetMetadataRequested(options, onSuccess, onError) {
On 2014/07/07 08:30:44, hirono wrote:
> Could you use test_util.onGetMetadataRequestedDefault?

Sure. I'll rebase once it gets committed.

https://codereview.chromium.org/375543002/diff/1/chrome/test/data/extensions/...
chrome/test/data/extensions/api_test/file_system_provider/delete_entry/test.js:139:
TESTING_B_DIRECTORY.name) {
On 2014/07/07 08:30:44, hirono wrote:
> The recursive flag is needed for deleting TESTING_B_DIRECTORY?

TESTING_B_DIRECTORY is in TESTING_A_DIRECTORY. Recursive flag is hence required
to remove TESTING_A_DIRECTORY, since it is not empty.

[hirono, 2014-07-07 08:37:51]

https://codereview.chromium.org/375543002/diff/1/chrome/test/data/extensions/...
File
chrome/test/data/extensions/api_test/file_system_provider/delete_entry/test.js
(right):

https://codereview.chromium.org/375543002/diff/1/chrome/test/data/extensions/...
chrome/test/data/extensions/api_test/file_system_provider/delete_entry/test.js:139:
TESTING_B_DIRECTORY.name) {
On 2014/07/07 08:33:11, mtomasz wrote:
> On 2014/07/07 08:30:44, hirono wrote:
> > The recursive flag is needed for deleting TESTING_B_DIRECTORY?
> 
> TESTING_B_DIRECTORY is in TESTING_A_DIRECTORY. Recursive flag is hence
required
> to remove TESTING_A_DIRECTORY, since it is not empty.

So shouldn't the if statement at #137 pass the options.entryPath of
TESTING_B_DIRECTORY? (nit since the flow is not used in the test)

[mtomasz, 2014-07-07 09:01:01]

https://codereview.chromium.org/375543002/diff/1/chrome/test/data/extensions/...
File
chrome/test/data/extensions/api_test/file_system_provider/delete_entry/test.js
(right):

https://codereview.chromium.org/375543002/diff/1/chrome/test/data/extensions/...
chrome/test/data/extensions/api_test/file_system_provider/delete_entry/test.js:139:
TESTING_B_DIRECTORY.name) {
On 2014/07/07 08:37:50, hirono wrote:
> On 2014/07/07 08:33:11, mtomasz wrote:
> > On 2014/07/07 08:30:44, hirono wrote:
> > > The recursive flag is needed for deleting TESTING_B_DIRECTORY?
> > 
> > TESTING_B_DIRECTORY is in TESTING_A_DIRECTORY. Recursive flag is hence
> required
> > to remove TESTING_A_DIRECTORY, since it is not empty.
> 
> So shouldn't the if statement at #137 pass the options.entryPath of
> TESTING_B_DIRECTORY? (nit since the flow is not used in the test)
> 

Got it. You're right. Fixed.

[hirono, 2014-07-07 09:22:16]

lgtm. Thank you!

[mtomasz, 2014-07-08 02:17:35]

@kalman: PTAL at IDL, since @benwells is OOO. Thanks.

[not at google - send to devlin, 2014-07-08 16:30:18]

https://codereview.chromium.org/375543002/diff/20001/chrome/common/extensions...
File chrome/common/extensions/api/file_system_provider.idl (right):

https://codereview.chromium.org/375543002/diff/20001/chrome/common/extensions...
chrome/common/extensions/api/file_system_provider.idl:251: [maxListeners=1,
nodoc] static void onDeleteEntryRequested(
I have exactly the same comments on this CL as the other one.

[mtomasz, 2014-07-11 05:17:56]

On 2014/07/08 16:30:18, kalman (OOO July 11-14) wrote:
>
https://codereview.chromium.org/375543002/diff/20001/chrome/common/extensions...
> File chrome/common/extensions/api/file_system_provider.idl (right):
> 
>
https://codereview.chromium.org/375543002/diff/20001/chrome/common/extensions...
> chrome/common/extensions/api/file_system_provider.idl:251: [maxListeners=1,
> nodoc] static void onDeleteEntryRequested(
> I have exactly the same comments on this CL as the other one.

@kalman: TBR, since your questions were addressed in a separate CL.

[mtomasz, 2014-07-11 06:22:07]

The CQ bit was checked by mtomasz@chromium.org

[commit-bot: I haz the power, 2014-07-11 06:22:49]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mtomasz@chromium.org/375543002/40001

[commit-bot: I haz the power, 2014-07-11 10:29:55]

Change committed as 282605