[MediaGalleries] Add context menu for forgetting galleries. [views]

chrome/browser/media_galleries/media_galleries_dialog_controller.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/media_galleries/media_galleries_dialog_controller.h"
 
 #include "base/path_service.h"
 #include "base/stl_util.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/media_galleries/media_file_system_registry.h"
 #include "chrome/browser/media_galleries/media_galleries_histograms.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/storage_monitor/storage_info.h"
 #include "chrome/browser/storage_monitor/storage_monitor.h"
 #include "chrome/browser/ui/chrome_select_file_policy.h"
 #include "chrome/common/chrome_paths.h"
 #include "chrome/common/extensions/extension.h"
 #include "chrome/common/extensions/permissions/media_galleries_permission.h"
 #include "chrome/common/extensions/permissions/permissions_data.h"
 #include "content/public/browser/web_contents.h"
 #include "content/public/browser/web_contents_view.h"
 #include "grit/generated_resources.h"
 #include "ui/base/l10n/l10n_util.h"
+#include "ui/base/models/simple_menu_model.h"
 #include "ui/base/text/bytes_formatting.h"
 
 using extensions::APIPermission;
 using extensions::Extension;
 
 namespace {
 
 // Comparator for sorting GalleryPermissionsVector -- sorts
 // allowed galleries low, and then sorts by absolute path.
 bool GalleriesVectorComparator(
     const MediaGalleriesDialogController::GalleryPermission& a,
     const MediaGalleriesDialogController::GalleryPermission& b) {
   if (a.allowed && !b.allowed)
     return true;
   if (!a.allowed && b.allowed)
     return false;
 
   return a.pref_info.AbsolutePath() < b.pref_info.AbsolutePath();
 }
 
 }  // namespace
 
+class GalleryContextMenuModel : public ui::SimpleMenuModel::Delegate {
+ public:
+  explicit GalleryContextMenuModel(MediaGalleriesDialogController* controller)
+      : controller_(controller), id_(kInvalidMediaGalleryPrefId) {}
+  virtual ~GalleryContextMenuModel() {}
+
+  void set_media_gallery_pref_id(MediaGalleryPrefId id) {
+    id_ = id;
+  }
+
+  virtual bool IsCommandIdChecked(int command_id) const OVERRIDE {
+    return false;
+  }
+  virtual bool IsCommandIdEnabled(int command_id) const OVERRIDE {
+    return true;
+  }
+  virtual bool IsCommandIdVisible(int command_id) const OVERRIDE {
+    return true;
+  }
+
+  virtual bool GetAcceleratorForCommandId(
+      int command_id, ui::Accelerator* accelerator) OVERRIDE {
+    return false;
+  }
+
+  virtual void ExecuteCommand(int command_id, int event_flags) OVERRIDE {
+    controller_->DidForgetGallery(id_);
+  }
+
+ private:
+  MediaGalleriesDialogController* controller_;
+  MediaGalleryPrefId id_;
+};
+
 MediaGalleriesDialogController::MediaGalleriesDialogController(
     content::WebContents* web_contents,
     const Extension& extension,
     const base::Closure& on_finish)
       : web_contents_(web_contents),
         extension_(&extension),
         on_finish_(on_finish) {
   preferences_ =
       g_browser_process->media_file_system_registry()->GetPreferences(
           Profile::FromBrowserContext(web_contents_->GetBrowserContext()));
   // Passing unretained pointer is safe, since the dialog controller
   // is self-deleting, and so won't be deleted until it can be shown
   // and then closed.
   preferences_->EnsureInitialized(
       base::Bind(&MediaGalleriesDialogController::OnPreferencesInitialized,
                  base::Unretained(this)));
+
+  gallery_menu_model_.reset(new GalleryContextMenuModel(this));
+  ui::SimpleMenuModel* menu_model =
+      new ui::SimpleMenuModel(gallery_menu_model_.get());
+  menu_model->AddItem(1, GetDeleteMenuCommand());

[vandebo (ex-Chrome), 2013/10/29 14:55:17]

Now that this is in the controller, you don't need GetDeleteMenuCommand()

[Greg Billock, 2013/10/29 17:04:06]

Done.

+  context_menu_model_.reset(menu_model);
 }
 
 void MediaGalleriesDialogController::OnPreferencesInitialized() {
   InitializePermissions();
 
   dialog_.reset(MediaGalleriesDialog::Create(this));
 
   StorageMonitor::GetInstance()->AddObserver(this);
 
   preferences_->AddGalleryChangeObserver(this);
@@ skipping 36 matching lines @@
   else
     id = IDS_MEDIA_GALLERIES_DIALOG_SUBTEXT_READ_ONLY;
 
   return l10n_util::GetStringFUTF16(id, UTF8ToUTF16(extension_->name()));
 }
 
 string16 MediaGalleriesDialogController::GetUnattachedLocationsHeader() const {
   return l10n_util::GetStringUTF16(IDS_MEDIA_GALLERIES_UNATTACHED_LOCATIONS);
 }
 
+string16 MediaGalleriesDialogController::GetDeleteMenuCommand() const {
+  return l10n_util::GetStringUTF16(IDS_MEDIA_GALLERIES_DIALOG_DELETE);
+}
+
 // TODO(gbillock): Call this something a bit more connected to the
 // messaging in the dialog.
 bool MediaGalleriesDialogController::HasPermittedGalleries() const {
   for (KnownGalleryPermissions::const_iterator iter = known_galleries_.begin();
        iter != known_galleries_.end(); ++iter) {
     if (iter->second.allowed)
       return true;
   }
 
   // Do this? Views did.
@@ skipping 82 matching lines @@
   for (GalleryPermissionsVector::iterator iter = new_galleries_.begin();
        iter != new_galleries_.end(); ++iter) {
     if (iter->pref_info.path == gallery.path &&
         iter->pref_info.device_id == gallery.device_id) {
       iter->allowed = enabled;
       return;
     }
   }
 }
 
+void MediaGalleriesDialogController::DidForgetGallery(
+    MediaGalleryPrefId pref_id) {
+  DCHECK(preferences_);
+  preferences_->ForgetGalleryById(pref_id);
+}
+
 void MediaGalleriesDialogController::DialogFinished(bool accepted) {
   // The dialog has finished, so there is no need to watch for more updates
   // from |preferences_|. Do this here and not in the dtor since this is the
   // only non-test code path that deletes |this|. The test ctor never adds
   // this observer in the first place.
   preferences_->RemoveGalleryChangeObserver(this);
 
   if (accepted)
     SavePermissions();
 
@@ skipping 174 matching lines @@
   }
 
   dialog_->UpdateGalleries();
 }
 
 void MediaGalleriesDialogController::UpdateGalleriesOnDeviceEvent(
     const std::string& device_id) {
   dialog_->UpdateGalleries();
 }
 
+ui::MenuModel* MediaGalleriesDialogController::GetContextMenuModel(
+    MediaGalleryPrefId id) {
+  gallery_menu_model_->set_media_gallery_pref_id(id);
+  return context_menu_model_.get();
+}
+
 // MediaGalleries dialog -------------------------------------------------------
 
 MediaGalleriesDialog::~MediaGalleriesDialog() {}