[ServiceWorker] Propagates ServiceWorker fetched response's URL and wasFetchedViaServiceWorker flag.

content/child/resource_dispatcher.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // See http://dev.chromium.org/developers/design-documents/multi-process-resource-loading
 
 #include "content/child/resource_dispatcher.h"
 
 #include "base/basictypes.h"
 #include "base/bind.h"
@@ skipping 340 matching lines @@
   request_info->response_start = ConsumeIOTimestamp();
 
   if (delegate_) {
     RequestPeer* new_peer =
         delegate_->OnReceivedResponse(
             request_info->peer, response_head.mime_type, request_info->url);
     if (new_peer)
       request_info->peer = new_peer;
   }
 
+  // Updates the response_url if the response was fetched via a ServiceWorker,
+  // and it was not generated inside the ServiceWorker.
+  if (response_head.was_fetched_via_service_worker &&
+      !response_head.original_url_via_service_worker.is_empty()) {
+    request_info->response_url = response_head.original_url_via_service_worker;

[Mike West, 2014/07/09 12:14:46]

Is overwriting the response url the right thing to do (here and in
WebURLLoaderImpl::Context::OnReceivedResponse)?

If I request `https://example.com/yay` on a site whose CSP only allows
`example.com`, don't we want to be able to reject resources from
`not-example.com` if the Service Worker delivers them in response?

Likewise, when we do CORS checks, don't we need to know that the response should
be treated as opaque?

Perhaps this would be clearer if you spell out in another CL exactly what the
Blink-side checks will look like.

[horo, 2014/07/10 06:17:56]

I think it's ok to overwrite the response url here, because it is also
overwritten in ResourceDispatcher::OnReceivedRedirect()
But I'm not sure it is really correct.
Do you know who to ask?


I'm planning to do CSP and CORS checks in ResourceFetcher::didReceiveResponse()
and DocumentThreadableLoader::handleResponse() in blink side.

The following are WIP patch for the check.
https://codereview.chromium.org/333423004/diff/1700001/Source/core/fetch/Reso...
https://codereview.chromium.org/333423004/diff/1700001/Source/core/loader/Doc...

+  }
+
   ResourceResponseInfo renderer_response_info;
   ToResourceResponseInfo(*request_info, response_head, &renderer_response_info);
   request_info->site_isolation_metadata =
       SiteIsolationPolicy::OnReceivedResponse(request_info->frame_origin,
                                               request_info->response_url,
                                               request_info->resource_type,
                                               request_info->origin_pid,
                                               renderer_response_info);
   request_info->peer->OnReceivedResponse(renderer_response_info);
 }
@@ skipping 481 matching lines @@
 void ResourceDispatcher::ReleaseResourcesInMessageQueue(MessageQueue* queue) {
   while (!queue->empty()) {
     IPC::Message* message = queue->front();
     ReleaseResourcesInDataMessage(*message);
     queue->pop_front();
     delete message;
   }
 }
 
 }  // namespace content