Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 375503009: Add gdbinit to tools/ directory. (Closed)

Created:
6 years, 5 months ago by Jakob Kummerow
Modified:
6 years, 5 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Add gdbinit to tools/ directory. Suggested usage: echo "source /path/to/v8/tools/gdbinit" >> ~/.gdbinit R=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22252

Patch Set 1 #

Patch Set 2 : add copyright header #

Total comments: 8

Patch Set 3 : comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -0 lines) Patch
A tools/gdbinit View 1 2 1 chunk +33 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Jakob Kummerow
6 years, 5 months ago (2014-07-07 15:23:35 UTC) #1
Michael Starzinger
LGTM with suggestions. https://codereview.chromium.org/375503009/diff/40001/tools/gdbinit File tools/gdbinit (right): https://codereview.chromium.org/375503009/diff/40001/tools/gdbinit#newcode4 tools/gdbinit:4: nit: I have this comment in ...
6 years, 5 months ago (2014-07-07 16:14:30 UTC) #2
Jakob Kummerow
Thanks, landing. https://codereview.chromium.org/375503009/diff/40001/tools/gdbinit File tools/gdbinit (right): https://codereview.chromium.org/375503009/diff/40001/tools/gdbinit#newcode4 tools/gdbinit:4: On 2014/07/07 16:14:30, Michael Starzinger wrote: > ...
6 years, 5 months ago (2014-07-07 16:21:19 UTC) #3
Jakob Kummerow
6 years, 5 months ago (2014-07-07 16:21:41 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 manually as r22252 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698