Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(910)

Issue 375503003: Revert of Add SSE4 version of BlurImage optimizations. (Closed)

Created:
6 years, 5 months ago by reed2
Modified:
6 years, 5 months ago
Reviewers:
henrik.smiding, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Revert of Add SSE4 version of BlurImage optimizations. (https://codereview.chromium.org/366593004/) Reason for revert: breaks linker on chrome [04:36:09.966000] [503/5965] LIB obj\chrome\installer_util.lib [04:36:10.466000] FAILED: C:\Users\chrome-bot\buildbot\third_party\depot_tools\python276_bin\python.exe gyp-win-tool link-with-manifests environment.x86 True skia.dll "C:\Users\chrome-bot\buildbot\third_party\depot_tools\python276_bin\python.exe gyp-win-tool link-wrapper environment.x86 False link.exe /nologo /IMPLIB:skia.dll.lib /DLL /OUT:skia.dll @skia.dll.rsp" 2 mt.exe rc.exe "obj\skia\skia.skia.dll.intermediate.manifest" obj\skia\skia.skia.dll.generated.manifest [04:36:10.466000] skia.opts_check_x86.obj : error LNK2019: unresolved external symbol "bool __cdecl SkBoxBlurGetPlatformProcs_SSE4(void (__cdecl**)(unsigned int const *,int,unsigned int *,int,int,int,int,int),void (__cdecl**)(unsigned int const *,int,unsigned int *,int,int,int,int,int),void (__cdecl**)(unsigned int const *,int,unsigned int *,int,int,int,int,int),void (__cdecl**)(unsigned int const *,int,unsigned int *,int,int,int,int,int))" (?SkBoxBlurGetPlatformProcs_SSE4@@YA_NPAP6AXPBIHPAIHHHHH@Z222@Z) referenced in function "bool __cdecl SkBoxBlurGetPlatformProcs(void (__cdecl**)(unsigned int const *,int,unsigned int *,int,int,int,int,int),void (__cdecl**)(unsigned int const *,int,unsigned int *,int,int,int,int,int),void (__cdecl**)(unsigned int const *,int,unsigned int *,int,int,int,int,int),void (__cdecl**)(unsigned int const *,int,unsigned int *,int,int,int,int,int))" (?SkBoxBlurGetPlatformProcs@@YA_NPAP6AXPBIHPAIHHHHH@Z222@Z) [04:36:10.466000] [04:36:10.466000] skia.dll : fatal error LNK1120: 1 unresolved externals Original issue's description: > Add SSE4 version of BlurImage optimizations. > > Adds an SSE4.1 version of the existing BlurImage optimizations. > Performance of blur_image_filter_* benchmarks show a 10-50% > improvement on Linux/Ubuntu Core i7. > > Signed-off-by: Henrik Smiding <henrik.smiding@intel.com>; > > Committed: https://skia.googlesource.com/skia/+/2830632ce93c97ed7647b13348365ea92e4ea665 TBR=mtklein@google.com,henrik.smiding@intel.com NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/82cb86f613300aa26f858e8f46454b1a8a5e2314

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -179 lines) Patch
M gyp/opts.gyp View 1 chunk +11 lines, -28 lines 0 comments Download
M src/opts/SkBlurImage_opts_SSE2.cpp View 1 chunk +6 lines, -2 lines 0 comments Download
D src/opts/SkBlurImage_opts_SSE4.h View 1 chunk +0 lines, -18 lines 0 comments Download
D src/opts/SkBlurImage_opts_SSE4.cpp View 1 chunk +0 lines, -123 lines 0 comments Download
M src/opts/opts_check_x86.cpp View 2 chunks +4 lines, -8 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
reed2
Created Revert of Add SSE4 version of BlurImage optimizations.
6 years, 5 months ago (2014-07-07 01:50:24 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/reed@chromium.org/375503003/1
6 years, 5 months ago (2014-07-07 01:51:24 UTC) #2
commit-bot: I haz the power
6 years, 5 months ago (2014-07-07 01:51:34 UTC) #3
Message was sent while issue was closed.
Change committed as 82cb86f613300aa26f858e8f46454b1a8a5e2314

Powered by Google App Engine
This is Rietveld 408576698