Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1985)

Unified Diff: build/common.gypi

Issue 375483003: Change Android toolchain to GCC 4.9. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove workaround for MIPS Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index 349decf49a82242f6e8fd3ec7f97653359b7791f..d822fa7ea1f04d8ef6b47e6052b5813cb7b4d2c4 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -1500,7 +1500,7 @@
'conditions': [
['OS=="android"', {
# We directly set the gcc versions since we know what we use.
- 'gcc_version%': 48,
+ 'gcc_version%': 49,
}, {
'gcc_version%': '<!pymod_do_main(compiler_version target compiler)',
}],
@@ -1646,7 +1646,7 @@
'android_gdbserver%': '<(android_ndk_root)/prebuilt/android-x86/gdbserver/gdbserver',
'android_ndk_sysroot%': '<(android_ndk_root)/platforms/android-14/arch-x86',
'android_ndk_lib_dir%': 'usr/lib',
- 'android_toolchain%': '<(android_ndk_root)/toolchains/x86-4.8/prebuilt/<(host_os)-<(android_host_arch)/bin',
+ 'android_toolchain%': '<(android_ndk_root)/toolchains/x86-4.9/prebuilt/<(host_os)-<(android_host_arch)/bin',
}],
['target_arch == "x64"', {
'android_app_abi%': 'x86_64',
@@ -1666,7 +1666,7 @@
'android_gdbserver%': '<(android_ndk_root)/prebuilt/android-arm/gdbserver/gdbserver',
'android_ndk_sysroot%': '<(android_ndk_root)/platforms/android-14/arch-arm',
'android_ndk_lib_dir%': 'usr/lib',
- 'android_toolchain%': '<(android_ndk_root)/toolchains/arm-linux-androideabi-4.8/prebuilt/<(host_os)-<(android_host_arch)/bin',
+ 'android_toolchain%': '<(android_ndk_root)/toolchains/arm-linux-androideabi-4.9/prebuilt/<(host_os)-<(android_host_arch)/bin',
}],
['target_arch == "arm64"', {
'android_app_abi%': 'arm64-v8a',
@@ -1680,7 +1680,7 @@
'android_gdbserver%': '<(android_ndk_root)/prebuilt/android-mips/gdbserver/gdbserver',
'android_ndk_sysroot%': '<(android_ndk_root)/platforms/android-14/arch-mips',
'android_ndk_lib_dir%': 'usr/lib',
- 'android_toolchain%': '<(android_ndk_root)/toolchains/mipsel-linux-android-4.8/prebuilt/<(host_os)-<(android_host_arch)/bin',
+ 'android_toolchain%': '<(android_ndk_root)/toolchains/mipsel-linux-android-4.9/prebuilt/<(host_os)-<(android_host_arch)/bin',
}],
],
},
@@ -3698,14 +3698,14 @@
}],
['arm_thumb==1', {
'cflags': [
- '-mthumb',
- ]
+ '-mthumb',
+ ],
}],
['OS=="android"', {
# Most of the following flags are derived from what Android
# uses by default when building for arm, reference for which
# can be found in the following file in the Android NDK:
- # toolchains/arm-linux-androideabi-4.8/setup.mk
+ # toolchains/arm-linux-androideabi-4.9/setup.mk
'cflags': [
# The tree-sra optimization (scalar replacement for
# aggregates enabling subsequent optimizations) leads to
@@ -3713,14 +3713,9 @@
# compiler (r5-r7). This can be verified using
# webkit_unit_tests' WTF.Checked_int8_t test.
'-fno-tree-sra',
- # The following 6 options are disabled to save on
- # binary size in gcc 4.8.
+ # The following option is disabled to improve binary
+ # size and performance in gcc 4.9.
# TODO(fdegans) Reevaluate when we upgrade GCC.
pasko 2014/07/28 13:14:30 nit: I think there is no need to have a TODO for
Fabrice (no longer in Chrome) 2014/07/28 13:40:43 Done.
- '-fno-partial-inlining',
- '-fno-early-inlining',
- '-fno-tree-copy-prop',
- '-fno-tree-loop-optimize',
- '-fno-move-loop-invariants',
'-fno-caller-saves',
'-Wno-psabi',
],
@@ -3757,11 +3752,6 @@
'-mthumb-interwork',
'-finline-limit=64',
'-fno-tree-sra',
- '-fno-partial-inlining',
- '-fno-early-inlining',
- '-fno-tree-copy-prop',
- '-fno-tree-loop-optimize',
- '-fno-move-loop-invariants',
'-fno-caller-saves',
'-Wno-psabi',
],
@@ -5527,7 +5517,7 @@
},
}],
# Don't warn about the "typedef 'foo' locally defined but not used"
- # for gcc 4.8.
+ # for gcc 4.8 and higher.
# TODO: remove this flag once all builds work. See crbug.com/227506
['gcc_version>=48 and clang==0', {
'target_defaults': {

Powered by Google App Engine
This is Rietveld 408576698