build/config/gcc/gcc_version.gni - Issue 375483003: Change Android toolchain to GCC 4.9.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: build/config/gcc/gcc_version.gni

Issue 375483003: Change Android toolchain to GCC 4.9. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove workaround for MIPS Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 # Copyright 2014 The Chromium Authors. All rights reserved.	1 # Copyright 2014 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 if (is_android) {	5 if (is_android) {

6 gcc_version = 48	6 gcc_version = 49
pasko 2014/07/28 13:14:30 does it mean this is currently wrong for aarch64? does it mean this is currently wrong for aarch64? does this have the same effect as gcc_version% in common.gypi? Fabrice (no longer in Chrome) 2014/07/28 13:40:43 Currently, it's wrong in gyp too. Though I haven't Show quoted text On 2014/07/28 13:14:30, pasko wrote: > does it mean this is currently wrong for aarch64? does this have the same effect > as gcc_version% in common.gypi? Currently, it's wrong in gyp too. Though I haven't encountered a breaking change with GCC 4.9 so it's not that bad.
7 } else {	7 } else {

8 gcc_version = exec_script("../../compiler_version.py", [ "host", "compiler" ] , "value")	8 gcc_version = exec_script("../../compiler_version.py", [ "host", "compiler" ] , "value")

9 }	9 }

OLD	NEW

« build/config/compiler/BUILD.gn ('K') | « build/config/compiler/BUILD.gn ('k') | no next file » | no next file with comments »