Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issue 375403003: cc: Refactor in picture_pile.cc (Closed)

Created:
6 years, 5 months ago by hyunki
Modified:
6 years, 5 months ago
Reviewers:
danakj, enne (OOO)
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

cc: Refactor in picture_pile.cc This is a minor refactor, that changes function names. BUG=NONE Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282244

Patch Set 1 #

Total comments: 4

Patch Set 2 : Address nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -9 lines) Patch
M cc/resources/picture_pile.cc View 1 4 chunks +9 lines, -9 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
hyunki
PTAL. Thanks. :)
6 years, 5 months ago (2014-07-09 17:36:38 UTC) #1
enne (OOO)
https://codereview.chromium.org/375403003/diff/1/cc/resources/picture_pile.cc File cc/resources/picture_pile.cc (left): https://codereview.chromium.org/375403003/diff/1/cc/resources/picture_pile.cc#oldcode28 cc/resources/picture_pile.cc:28: bool rect_sort_y(const gfx::Rect &r1, const gfx::Rect &r2) { This ...
6 years, 5 months ago (2014-07-09 17:38:34 UTC) #2
hyunki
Thanks. PTAL.
6 years, 5 months ago (2014-07-09 17:46:55 UTC) #3
hyunki
https://codereview.chromium.org/375403003/diff/1/cc/resources/picture_pile.cc File cc/resources/picture_pile.cc (left): https://codereview.chromium.org/375403003/diff/1/cc/resources/picture_pile.cc... cc/resources/picture_pile.cc:28: bool rect_sort_y(const gfx::Rect &r1, const gfx::Rect &r2) { On ...
6 years, 5 months ago (2014-07-09 17:47:27 UTC) #4
hyunki
Sorry. I have made duplicated replay for the comment. Ping PTAL. Thanks.
6 years, 5 months ago (2014-07-10 00:01:59 UTC) #5
enne (OOO)
Sure, lgtm.
6 years, 5 months ago (2014-07-10 00:05:12 UTC) #6
enne (OOO)
The CQ bit was checked by enne@chromium.org
6 years, 5 months ago (2014-07-10 00:05:15 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hyunki.baik@samsung.com/375403003/20001
6 years, 5 months ago (2014-07-10 00:06:57 UTC) #8
commit-bot: I haz the power
6 years, 5 months ago (2014-07-10 03:47:47 UTC) #9
Message was sent while issue was closed.
Change committed as 282244

Powered by Google App Engine
This is Rietveld 408576698